Nov 16, 2024 · Nov 14, 2024 · Nov 15, 2024 · Nov 16, 2024
diff --git a/packages/eslint-plugin/src/rules/no-deprecated.ts b/packages/eslint-plugin/src/rules/no-deprecated.ts
      while (true) {
        switch (current.type) {
          case AST_NODE_TYPES.ExportAllDeclaration:
          case AST_NODE_TYPES.ExportDefaultDeclaration:
          case AST_NODE_TYPES.ExportNamedDeclaration:
          case AST_NODE_TYPES.ImportDeclaration:
            return true;
diff --git a/packages/eslint-plugin/tests/rules/no-deprecated.test.ts b/packages/eslint-plugin/tests/rules/no-deprecated.test.ts

      a('b');
    `,
    `
      function a(value: 'b' | undefined): void;
      /** @deprecated */
      function a(value: 'c' | undefined): void;
      function a(value: string | undefined): void {
        // ...
      }

      export default a('b');
    `,
    `
      function notDeprecated(): object {
        return {};
      }

      export default notDeprecated();
    `,
    `
      import { deprecatedFunctionWithOverloads } from './deprecated';

        },
      ],
    },
    {
      code: `
        /** @deprecated */
        function a(): object {
          return {};
        }

        export default a();
      `,
      errors: [
        {
          column: 24,
          data: { name: 'a' },
          endColumn: 25,
          endLine: 7,
          line: 7,
          messageId: 'deprecated',
        },
      ],
    },
  ],
 });
Original file line number	Diff line number	Diff line change
Expand Up		@@ -127,7 +127,6 @@ export default createRule({
		while (true) {
		switch (current.type) {
		case AST_NODE_TYPES.ExportAllDeclaration:
		case AST_NODE_TYPES.ExportDefaultDeclaration:
		case AST_NODE_TYPES.ExportNamedDeclaration:
		case AST_NODE_TYPES.ImportDeclaration:
		return true;
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -100,6 +100,23 @@ ruleTester.run('no-deprecated', rule, {

		a('b');
		`,
		`
Copy link Member kirkwaiblingerNov 15, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This test is a fine test of overloaded function signature logic! I'm happy for us to keep it around, but I think for the sake of this issue we should also have a test purely for the default export usage that's as simple as functionnotDeprecated(){return{};}exportdefaultnotDeprecated(); Copy link ContributorAuthor wszydlakNov 16, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Added additional valid test 🙂 kirkwaiblinger reacted with thumbs up emoji
		function a(value: 'b' \| undefined): void;
		/** @deprecated */
		function a(value: 'c' \| undefined): void;
		function a(value: string \| undefined): void {
		// ...
		}

		export default a('b');
		`,
		`
		function notDeprecated(): object {
		return {};
		}

		export default notDeprecated();
		`,
		`
		import { deprecatedFunctionWithOverloads } from './deprecated';

Expand DownExpand Up		@@ -2463,5 +2480,25 @@ ruleTester.run('no-deprecated', rule, {
		},
		],
		},
		{
		code: `
		/** @deprecated */
		function a(): object {
		return {};
		}

		export default a();
		`,
		errors: [
		{
		column: 24,
		data: { name: 'a' },
		endColumn: 25,
		endLine: 7,
		line: 7,
		messageId: 'deprecated',
		},
		],
		},
		],
		});