typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): [no-base-to-string] check Array.prototype.join#10287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 8 commits intotypescript-eslint:mainfromyeonjuan:feat/3388

Nov 24, 2024

Merged

feat(eslint-plugin): [no-base-to-string] check Array.prototype.join#10287

JoshuaKGoldberg merged 8 commits intotypescript-eslint:mainfromyeonjuan:feat/3388

Nov 24, 2024

Conversation

Copy link

Contributor

PR Checklist

Addresses an existing open issue:fixes[no-base-to-string] add option to prevent usage of Array .join on non-toString things #3388
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

feat(eslint-plugin): [no-base-to-string] add checkArrayJoin option

5750ebc

Copy link

Contributor

typescript-eslintbot commentedNov 5, 2024

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 5, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`6595fd5`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/673b7bc061acbe00083a25cb
😎 Deploy Preview	https://deploy-preview-10287--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedNov 5, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit6595fd5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

Merge branch 'main' into feat/3388

e457859

Copy link

codecovbot commentedNov 6, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base(c13b6b4) to head(6595fd5).
Report is 44 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10287      +/-   ##==========================================+ Coverage   86.56%   86.72%   +0.15%==========================================  Files         431      434       +3       Lines       15188    15246      +58       Branches     4418     4446      +28     ==========================================+ Hits        13148    13222      +74+ Misses       1683     1668      -15+ Partials      357      356       -1

Flag	Coverage Δ
unittest	`86.72% <100.00%> (+0.15%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`98.87% <100.00%> (+3.16%)`	⬆️

... and56 files with indirect coverage changes

----🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

yeonjuan added2 commits

November 7, 2024 00:32

add test case

b7a0f17

update snapshot

68a3db2

yeonjuan marked this pull request as ready for review

November 6, 2024 17:12

kirkwaiblinger reviewed

Nov 8, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-base-to-string.ts OutdatedShow resolvedHide resolved

yeonjuan force-pushed thefeat/3388 branch from314d371 to504b212Compare

November 9, 2024 14:15

reviews

1fafc44

yeonjuan force-pushed thefeat/3388 branch from504b212 to1fafc44Compare

November 9, 2024 14:32

Copy link

Member

Josh-Cena commentedNov 10, 2024

IMO: this doesn't have to be an option. I can't think of a case where someone checks all other cases but wants to allowjoin on purpose.

kirkwaiblinger reviewed

Nov 11, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-base-to-string.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-base-to-string.test.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-base-to-string.ts OutdatedShow resolvedHide resolved

apply reviews

c79b0cc

Copy link

ContributorAuthor

yeonjuan commentedNov 12, 2024

@Josh-Cena @kirkwaiblinger Thank you for your review. I've fixed it.

yeonjuan changed the title~~feat(eslint-plugin): [no-base-to-string] add checkArrayJoin option~~feat(eslint-plugin): [no-base-to-string] check Array.prototype.join

Nov 13, 2024

kirkwaiblinger requested changes

Nov 16, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdxShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-base-to-string.test.tsShow resolvedHide resolved

kirkwaiblinger added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 16, 2024

improve certainty

b4d8a93

kirkwaiblinger requested changes

Nov 17, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/no-base-to-string.test.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-base-to-string.ts OutdatedShow resolvedHide resolved

apply reviews

6595fd5

yeonjuan force-pushed thefeat/3388 branch from630be53 to6595fd5Compare

November 18, 2024 17:39

kirkwaiblinger approved these changes

Nov 18, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I enjoy the fancy abstractions! 😀

kirkwaiblinger added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting responseIssues waiting for a reply from the OP or another party labels

Nov 18, 2024

JoshuaKGoldberg merged commit2e2433b intotypescript-eslint:main

Nov 24, 2024

66 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Nov 25, 2024

fix(deps): update typescript-eslint monorepo to v8.16.0

e003156

##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25)##### 🚀 Features-   **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287))-   **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Nov 25, 2024

fix(deps): update typescript-eslint monorepo to v8.16.0

7118c33

##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25)##### 🚀 Features-   **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287))-   **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Nov 26, 2024

fix(deps): update typescript-eslint monorepo to v8.16.0

1979d1d

##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25)##### 🚀 Features-   **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287))-   **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 26, 2024

Update typescript-eslint monorepo to v8.16.0

440d3e2

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.15.0 | 8.16.0 || npm        | @typescript-eslint/parser        | 8.15.0 | 8.16.0 |## [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25)##### 🚀 Features-   **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287))-   **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 6, 2024

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

4 participants

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [no-base-to-string] check Array.prototype.join#10287

feat(eslint-plugin): [no-base-to-string] check Array.prototype.join#10287

Uh oh!

Conversation

yeonjuan commentedNov 5, 2024

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedNov 5, 2024

Uh oh!

netlifybot commentedNov 5, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedNov 5, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedNov 6, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Josh-Cena commentedNov 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yeonjuan commentedNov 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

netlifybot commentedNov 5, 2024•
edited
Loading

nx-cloudbot commentedNov 5, 2024•
edited
Loading

codecovbot commentedNov 6, 2024•
edited
Loading