Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(scope-manager): fix asserted increments not being marked as write references#10271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromjanek515:main
Nov 10, 2024
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,5 +21,17 @@ let x: number | undefined = 1;
let x: number | undefined = 1;
(x as number) += 1;
`,
`
let x: number | undefined = 1;
x!++;
`,
`
let x: number | undefined = 1;
(<number>x)++;
`,
`
let x: number | undefined = 1;
(x as number)++;
`,
],
});
33 changes: 20 additions & 13 deletionspackages/scope-manager/src/referencer/Referencer.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,17 +325,7 @@ class Referencer extends Visitor {
}

protected AssignmentExpression(node: TSESTree.AssignmentExpression): void {
let left = node.left;
switch (left.type) {
case AST_NODE_TYPES.TSAsExpression:
case AST_NODE_TYPES.TSTypeAssertion:
// explicitly visit the type annotation
this.visitType(left.typeAnnotation);
// intentional fallthrough
case AST_NODE_TYPES.TSNonNullExpression:
// unwrap the expression
left = left.expression;
}
const left = this.visitExpressionTarget(node.left);

if (PatternVisitor.isPattern(left)) {
if (node.operator === '=') {
Expand DownExpand Up@@ -752,8 +742,10 @@ class Referencer extends Visitor {
}

protected UpdateExpression(node: TSESTree.UpdateExpression): void {
if (PatternVisitor.isPattern(node.argument)) {
this.visitPattern(node.argument, pattern => {
const argument = this.visitExpressionTarget(node.argument);

if (PatternVisitor.isPattern(argument)) {
this.visitPattern(argument, pattern => {
this.currentScope().referenceValue(
pattern,
ReferenceFlag.ReadWrite,
Expand DownExpand Up@@ -811,6 +803,21 @@ class Referencer extends Visitor {

this.close(node);
}

private visitExpressionTarget(left: TSESTree.Node) {
switch (left.type) {
case AST_NODE_TYPES.TSAsExpression:
case AST_NODE_TYPES.TSTypeAssertion:
// explicitly visit the type annotation
this.visitType(left.typeAnnotation);
// intentional fallthrough
case AST_NODE_TYPES.TSNonNullExpression:
// unwrap the expression
left = left.expression;
}

return left;
}
}

export { Referencer, type ReferencerOptions };
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
let x: number | undefined = 1;
(<number>x)++;

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
let x: number | undefined = 1;
(x as number)++;
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
let x: number | undefined = 1;
x!++;
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

Loading

[8]ページ先頭

©2009-2025 Movatter.jp