typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(scope-manager): fix asserted increments not being marked as write references#10271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromjanek515:main

Nov 10, 2024

Merged

fix(scope-manager): fix asserted increments not being marked as write references#10271

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromjanek515:main

Nov 10, 2024

Conversation

Copy link

Contributor

janek515 commentedNov 3, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [prefer-const] False positives when using increment operator with non-null assertion operator #10270
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR is analogous to#2809, but addresses increment operators.

fix(scope-manager): fix asserted increments not being marked as write…

7a71c58

… references

Copy link

Contributor

typescript-eslintbot commentedNov 3, 2024

Thanks for the PR,@janek515!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 3, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`edf6a58`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6730dc006011c400082cf6e2
😎 Deploy Preview	https://deploy-preview-10271--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedNov 3, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitedf6a58. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run-many --target=clean

Sent with 💌 fromNxCloud.

janek515 commented

Nov 3, 2024

View reviewed changes

packages/scope-manager/src/referencer/Referencer.ts Outdated

		@@ -752,8 +752,19 @@ class Referencer extends Visitor {
		}

		protected UpdateExpression(node: TSESTree.UpdateExpression): void {
		if (PatternVisitor.isPattern(node.argument)) {
		this.visitPattern(node.argument, pattern => {
		let argument = node.argument;

Copy link

ContributorAuthor

janek515Nov 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This could be extracted into a function (as it's the same as lines 328-338), but I have no idea how to name it.

Copy link

Member

JoshuaKGoldbergNov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good callout. Maybe...visitExpressionLeft?visitExpressionLeftBypassingAssertion? I'd put it at the end of// Visit helpers maybe.

Copy link

Member

JoshuaKGoldbergNov 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Coming back to this, I'll go withvisitExpressionTarget. Only the other one of the two is about the"left".

Copy link

codecovbot commentedNov 3, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is87.50000% with1 line in your changes missing coverage. Please review.

Project coverage is 86.57%. Comparing base(b347c04) to head(edf6a58).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...ackages/scope-manager/src/referencer/Referencer.ts	87.50%	0 Missing and 1 partial⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10271      +/-   ##==========================================+ Coverage   86.51%   86.57%   +0.06%==========================================  Files         430      431       +1       Lines       15123    15198      +75       Branches     4400     4421      +21     ==========================================+ Hits        13083    13158      +75  Misses       1683     1683                Partials      357      357

Flag	Coverage Δ
unittest	`86.57% <87.50%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...ackages/scope-manager/src/referencer/Referencer.ts	`97.18% <87.50%> (+0.02%)`	⬆️

... and15 files with indirect coverage changes

JoshuaKGoldberg previously approved these changes

Nov 4, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice and clean, well done! ✨

I don't mind a little bit of code duplication ("WET" and all), but would lean towards deduplicating. Whichever the next team member prefers is ok with me. 🙂

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Nov 4, 2024

visitExpressionTarget

edf6a58

JoshuaKGoldberg dismissed theirstale review viaedf6a58

November 10, 2024 16:14

JoshuaKGoldberg merged commit42d275c intotypescript-eslint:main

Nov 10, 2024

57 of 58 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Nov 11, 2024

fix(deps): update typescript-eslint monorepo to v8.14.0

ffd7e61

##### [v8.14.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8140-2024-11-11)##### 🚀 Features-   **eslint-plugin:** \[await-thenable] report unnecessary `await using` statements ([#10209](typescript-eslint/typescript-eslint#10209))-   **eslint-plugin:** \[no-confusing-void-expression] add an option to ignore void<->void ([#10067](typescript-eslint/typescript-eslint#10067))##### 🩹 Fixes-   **scope-manager:** fix asserted increments not being marked as write references ([#10271](typescript-eslint/typescript-eslint#10271))-   **eslint-plugin:** \[no-misused-promises] improve report loc for methods ([#10216](typescript-eslint/typescript-eslint#10216))-   **eslint-plugin:** \[no-unnecessary-condition] improve error message for literal comparisons ([#10194](typescript-eslint/typescript-eslint#10194))##### ❤️  Thank You-   Gyumong [@gyumong](https://github.com/Gyumong)-   Jan Ochwat [@janek515](https://github.com/janek515)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 12, 2024

Update typescript-eslint monorepo to v8.14.0

da248fc

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.13.0 | 8.14.0 || npm        | @typescript-eslint/parser        | 8.13.0 | 8.14.0 |## [v8.14.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8140-2024-11-11)##### 🚀 Features-   **eslint-plugin:** \[await-thenable] report unnecessary `await using` statements ([#10209](typescript-eslint/typescript-eslint#10209))-   **eslint-plugin:** \[no-confusing-void-expression] add an option to ignore void<->void ([#10067](typescript-eslint/typescript-eslint#10067))##### 🩹 Fixes-   **scope-manager:** fix asserted increments not being marked as write references ([#10271](typescript-eslint/typescript-eslint#10271))-   **eslint-plugin:** \[no-misused-promises] improve report loc for methods ([#10216](typescript-eslint/typescript-eslint#10216))-   **eslint-plugin:** \[no-unnecessary-condition] improve error message for literal comparisons ([#10194](typescript-eslint/typescript-eslint#10194))##### ❤️  Thank You-   Gyumong [@gyumong](https://github.com/Gyumong)-   Jan Ochwat [@janek515](https://github.com/janek515)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 12, 2024

Update typescript-eslint monorepo to v8.14.0

d376526

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.13.0 | 8.14.0 || npm        | @typescript-eslint/parser        | 8.13.0 | 8.14.0 |## [v8.14.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8140-2024-11-11)##### 🚀 Features-   **eslint-plugin:** \[await-thenable] report unnecessary `await using` statements ([#10209](typescript-eslint/typescript-eslint#10209))-   **eslint-plugin:** \[no-confusing-void-expression] add an option to ignore void<->void ([#10067](typescript-eslint/typescript-eslint#10067))##### 🩹 Fixes-   **scope-manager:** fix asserted increments not being marked as write references ([#10271](typescript-eslint/typescript-eslint#10271))-   **eslint-plugin:** \[no-misused-promises] improve report loc for methods ([#10216](typescript-eslint/typescript-eslint#10216))-   **eslint-plugin:** \[no-unnecessary-condition] improve error message for literal comparisons ([#10194](typescript-eslint/typescript-eslint#10194))##### ❤️  Thank You-   Gyumong [@gyumong](https://github.com/Gyumong)-   Jan Ochwat [@janek515](https://github.com/janek515)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Nov 18, 2024

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

2 participants

Movatterモバイル変換

Uh oh!

fix(scope-manager): fix asserted increments not being marked as write references#10271

fix(scope-manager): fix asserted increments not being marked as write references#10271

Uh oh!

Conversation

janek515 commentedNov 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedNov 3, 2024

Uh oh!

netlifybot commentedNov 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedNov 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

janek515Nov 3, 2024

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergNov 4, 2024

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergNov 10, 2024

Choose a reason for hiding this comment

Uh oh!

codecovbot commentedNov 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

janek515 commentedNov 3, 2024•
edited
Loading

netlifybot commentedNov 3, 2024•
edited
Loading

nx-cloudbot commentedNov 3, 2024•
edited
Loading

codecovbot commentedNov 3, 2024•
edited
Loading