Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: addoptions property toImportExpression node#10255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ota-meshi
Copy link
Contributor

PR Checklist

Overview

This PR adds theoptions property to theImportExpression node.

I made changes toast-spec,typescript-estree andvisitor-keys.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedOct 31, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf542702
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67279309c3f86b000820e446
😎 Deploy Previewhttps://deploy-preview-10255--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedOct 31, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf542702. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

@ota-meshi
Copy link
ContributorAuthor

ota-meshi commentedOct 31, 2024
edited
Loading

"Deploy Preview" is failing and I don't know why... Can you give me some advice?


Solved. I fixed the missing escaping required by JSDoc.

@ota-meshi
Copy link
ContributorAuthor

ota-meshi commentedNov 1, 2024
edited
Loading

Oh, it seems CI failed too, but looking at the logs I can't figure out why 😓


Solved, it was fixed when ran it again.

@codecovCodecov
Copy link

codecovbot commentedNov 1, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is0% with2 lines in your changes missing coverage. Please review.

Project coverage is 86.51%. Comparing base(3f34490) to head(676e283).
Report is 1 commits behind head on main.

Current head676e283 differs from pull request most recent headf542702

Pleaseupload reports for the commitf542702 to get more accurate results.

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts0.00%2 Missing⚠️
Additional details and impacted files
@@           Coverage Diff           @@##             main   #10255   +/-   ##=======================================  Coverage   86.51%   86.51%           =======================================  Files         430      430             Lines       15123    15098   -25       Branches     4400     4384   -16     =======================================- Hits        13083    13062   -21+ Misses       1683     1679    -4  Partials      357      357
FlagCoverage Δ
unittest86.51% <0.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/visitor-keys/src/visitor-keys.ts100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts28.88% <0.00%> (ø)

... and2 files with indirect coverage changes

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 3, 2024
@Josh-CenaJosh-Cenaenabled auto-merge (squash)November 3, 2024 15:13
@Josh-CenaJosh-Cena merged commitb347c04 intotypescript-eslint:mainNov 3, 2024
59 of 60 checks passed
@ota-meshiota-meshi deleted the import-attributes branchNovember 3, 2024 18:30
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@Josh-CenaJosh-CenaJosh-Cena approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Add theoptions property toImportExpression node
3 participants
@ota-meshi@bradzacher@Josh-Cena

[8]ページ先頭

©2009-2025 Movatter.jp