Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update eslint version internally to latest#10244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedOct 30, 2024•
edited
Loading

PR Checklist

Overview

  • yarn up eslint
  • fix some tests for no-useless-constructor extension rule

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedOct 30, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit436ff1d
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6727b680c93a9a0008d8636e
😎 Deploy Previewhttps://deploy-preview-10244--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedOct 30, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit436ff1d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedNov 1, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.51%. Comparing base(4af866a) to head(436ff1d).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10244   +/-   ##=======================================  Coverage   86.50%   86.51%           =======================================  Files         430      430             Lines       15088    15123   +35       Branches     4380     4400   +20     =======================================+ Hits        13052    13083   +31- Misses       1679     1683    +4  Partials      357      357
FlagCoverage Δ
unittest86.51% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 5 files with indirect coverage changes

@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewNovember 1, 2024 20:26
@@ -137,7 +137,6 @@
"@types/estree": "link:./tools/dummypkg",
"@types/node": "^20.0.0",
"@types/react": "^18.2.14",
"eslint": "^9",
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unsure of exactly what we wanna do with the various places the dependency is declared. I removed theresolutions field and didyarn up eslint. But, lmk if we want to manage it differently

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These changes are due toeslint/eslint#18799

kirkwaiblingerand others added2 commitsNovember 3, 2024 10:33
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@bradzacherbradzacher merged commitd90cc59 intotypescript-eslint:mainNov 4, 2024
66 of 68 checks passed
@kirkwaiblingerkirkwaiblinger deleted the eslint-latest branchNovember 4, 2024 16:45
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Upgrade to latest eslint internally
2 participants
@kirkwaiblinger@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp