This PRresolves#10228. Apparently, TypeScript has a different typewhen a property could be missing rather than the standardundefined type. Both types have the same object flags but differentdebugIntrinsicName, making them not match for the current equality check (along with a differentid key).

This issue isn't related to the recent fix in#10223 and can be tracked a while back. I didn't bother checking that the type is actually the missing type (it would require checking the currently untypeddebugIntrinsicName) and just comparing for the standard undefined object flags (which match both the standard and the missing undefined types).

don't report on the 'missing' undefined type if it's covered with an …

141eb59

…undefined type

Copy link

Contributor

typescript-eslintbot commentedOct 29, 2024

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 29, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`64a712c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/672266631efaa2000816cfc6
😎 Deploy Preview	https://deploy-preview-10232--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

ronami changed the title~~fix(eslint): [switch-exhaustiveness-check] add support for covering a missing property withundefined~~fix(eslint-plugin): [switch-exhaustiveness-check] add support for covering a missing property withundefined

Oct 29, 2024

Copy link

nx-cloudbot commentedOct 29, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit64a712c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedOct 29, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base(4af866a) to head(64a712c).
Report is 28 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10232   +/-   ##=======================================  Coverage   86.50%   86.50%           =======================================  Files         430      430             Lines       15088    15091    +3       Branches     4380     4382    +2     =======================================+ Hits        13052    13055    +3  Misses       1679     1679             Partials      357      357

Flag	Coverage Δ
unittest	`86.50% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts	`98.82% <100.00%> (+0.04%)`	⬆️

ronami added2 commits

October 29, 2024 22:56

projectService: false

f7ab3c4

projectService: false on valid test too

e52e44c

ronami marked this pull request as ready for review

October 29, 2024 21:14

auvred requested changes

Oct 30, 2024

View reviewed changes

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts OutdatedShow resolvedHide resolved

auvred added the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 30, 2024

ronamiand others added2 commits

October 30, 2024 18:57

Update packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts

674c158

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

add relevant test

64a712c

ronami requested a review fromauvred

October 30, 2024 17:18

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 30, 2024

This comment was marked as off-topic.

This comment was marked as off-topic.

auvred approved these changes

Nov 2, 2024

View reviewed changes

Copy link

Member

auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯

auvred added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Nov 2, 2024

JoshuaKGoldberg approved these changes

Nov 4, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yay!

JoshuaKGoldberg merged commitf83a591 intotypescript-eslint:main

Nov 4, 2024

65 checks passed

ronami deleted the switch-exhaustiveness-check-missing-type branch

November 4, 2024 14:25

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Nov 4, 2024

fix(deps): update typescript-eslint monorepo to v8.13.0

36eca14

##### [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

Copy link

Contributor

jtbandes commentedNov 5, 2024

Thanks for the quick turnaround :)

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 6, 2024

Update typescript-eslint monorepo to v8.13.0

12a50df

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.12.2 | 8.13.0 || npm        | @typescript-eslint/parser        | 8.12.2 | 8.13.0 |## [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 7, 2024

Update typescript-eslint monorepo to v8.13.0

486fea9

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.12.2 | 8.13.0 || npm        | @typescript-eslint/parser        | 8.12.2 | 8.13.0 |## [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Nov 13, 2024

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

6 participants

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [switch-exhaustiveness-check] add support for covering a missing property withundefined#10232

fix(eslint-plugin): [switch-exhaustiveness-check] add support for covering a missing property withundefined#10232

Uh oh!

Conversation

ronami commentedOct 29, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedOct 29, 2024

Uh oh!

netlifybot commentedOct 29, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedOct 29, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedOct 29, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

auvred left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jtbandes commentedNov 5, 2024

Uh oh!

Uh oh!

fix(eslint-plugin): [switch-exhaustiveness-check] add support for covering a missing property with`undefined`#10232

fix(eslint-plugin): [switch-exhaustiveness-check] add support for covering a missing property with`undefined`#10232

ronami commentedOct 29, 2024•
edited
Loading

netlifybot commentedOct 29, 2024•
edited
Loading

nx-cloudbot commentedOct 29, 2024•
edited
Loading

codecovbot commentedOct 29, 2024•
edited
Loading