similar to eslint's default-case rule, i modified to have the same effect as writing a default clause by specifying theno default comment. In the allowDefaultCaseForExhaustiveSwitch option, if no default is specified, an error may occur in the annotation in some cases, so it is necessary to review whether it is okay.

one additional work is left The option considerDefaultExhaustiveForUnions in PR#9954 is in preparation for merging, so you will need to write a test case for that option once this PR is merged.

feat: no default comment

b465b39

Copy link

Contributor

typescript-eslintbot commentedOct 27, 2024

Thanks for the PR,@developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 27, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f4709a5`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67546caafe98a900099860c0
😎 Deploy Preview	https://deploy-preview-10218--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedOct 27, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf4709a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedOct 27, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base(772bd43) to head(f4709a5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10218   +/-   ##=======================================  Coverage   86.77%   86.78%           =======================================  Files         444      444             Lines       15320    15328    +8       Branches     4461     4465    +4     =======================================+ Hits        13294    13302    +8  Misses       1672     1672             Partials      354      354

Flag	Coverage Δ
unittest	`86.78% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts	`98.92% <100.00%> (+0.10%)`	⬆️

developer-bandi added2 commits

October 28, 2024 20:51

merge main

a590cfd

feat: considerDefaultExhaustiveForUnions option apply

d394fd3

yeonjuan reviewed

Oct 28, 2024

View reviewed changes

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts OutdatedShow resolvedHide resolved

developer-bandi marked this pull request as draft

October 30, 2024 14:30

Copy link

ContributorAuthor

developer-bandi commentedOct 30, 2024

I will resolve the conflict by merging the changes to the considerDefaultExhaustiveForUnions option currently reflected in the main branch and request a review again.

developer-bandi added3 commits

November 2, 2024 13:42

Merge branch 'main' ofhttps://github.com/developer-bandi/typescript-…

cfb6ddc

…eslint into feature/switch-exhaustiveness-check-nodefaultcomment

feat: apply regex in no default

5761456

fix: test case fix

1e9aa95

developer-bandi marked this pull request as ready for review

November 2, 2024 06:20

bradzacher added the bugSomething isn't working label

Nov 3, 2024

bradzacher changed the title~~fix(eslint-plugin): [switch-exhaustiveness-check] add support for "no default" comment~~feat(eslint-plugin): [switch-exhaustiveness-check] add support for "no default" comment

Nov 3, 2024

bradzacher removed the bugSomething isn't working label

Nov 3, 2024

JoshuaKGoldberg requested changes

Nov 4, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I took a quick initial pass and think there should be an option added to maintain parity with ESLint core. I can take a deeper look once that's in (or if I'm wrong about that). Thanks!

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 4, 2024

fix: add defalutCaseCommentPattern option

6844c0f

developer-bandi requested a review fromJoshuaKGoldberg

November 7, 2024 14:41

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 7, 2024

JoshuaKGoldberg requested changes

Nov 10, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few necessities aren't filled in: docs and tests for the option. If you fill those in we can review more deeply. Thanks!

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/switch-exhaustiveness-check.test.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 10, 2024

developer-bandi added2 commits

November 13, 2024 20:07

feat: add testcase and docs

88fad95

fix:test case

966aebe

developer-bandi requested a review fromJoshuaKGoldberg

November 13, 2024 11:20

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 13, 2024

JoshuaKGoldberg requested changes

Nov 22, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Progress! 🚀

I'm not sure we want theno default as a default - so you might want to hold off changes until the discussion there resolves.

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 22, 2024

JoshuaKGoldberg requested a review fromkirkwaiblinger

November 22, 2024 19:24

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 22, 2024

developer-bandi added2 commits

December 2, 2024 23:26

fix: code review apply

764fd6b

Merge branch 'main' ofhttps://github.com/developer-bandi/typescript-…

e8ed38f

…eslint into feature/switch-exhaustiveness-check-nodefaultcomment

developer-bandi force-pushed thefeature/switch-exhaustiveness-check-nodefaultcomment branch from6e0b96c toe8ed38fCompare

December 3, 2024 14:21

developer-bandi requested a review fromJoshuaKGoldberg

December 3, 2024 14:21

FloEdelmann reviewed

Dec 4, 2024

View reviewed changes

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts

		@@ -14,9 +14,11 @@ import {
		requiresQuoting,
		} from '../util';

		const DEFAULT_COMMENT_PATTERN = /^no default$/iu;

Copy link

Contributor

FloEdelmannDec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If there's a default value, please specify it indefaultOptions.

Copy link

ContributorAuthor

developer-bandiDec 7, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

�In order to put a default value in defaultOptions, the defaultCaseCommentPattern option must be able to receive a flag. Therefore, this option should be in the form of an array, with an expression at the first index and a flag at the second index.

defaultCaseCommentPattern:["no default", "iu"]

Previously, the default value was treated as a separate variable because of equivalence with eslint rules. Would there be any problem with implementing it like this?

Copy link

Member

JoshuaKGoldbergDec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As much as I would love to keep things to thedefaultOptions plumbing, I don't think this is doable. I think this PR is fine as-is.

JoshuaKGoldberg mentioned this pull request

Dec 7, 2024

Bug: [prefer-nullish-coalescing] Doesn't report on ternary, but does on equivalent ||#10470

Closed

4 tasks

Update test snapshots

c7f743b

JoshuaKGoldberg previously approved these changes

Dec 7, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for all the iteration on this! Your hard work is paying off 🔥

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Dec 7, 2024

JoshuaKGoldberg reviewed

Dec 7, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx OutdatedShow resolvedHide resolved

Update packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

175681c

JoshuaKGoldberg dismissed theirstale review via175681c

December 7, 2024 14:59

JoshuaKGoldberg added3 commits

December 7, 2024 10:13

Fix regex complaint in code block

cbb3f81

Merge branch 'main' into feature/switch-exhaustiveness-check-nodefaul…

ebb20f8

…tcomment

update test snapshots in general

844a96c

JoshuaKGoldberg reviewed

Dec 7, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdxShow resolvedHide resolved

Apply suggestions from code review

f4709a5

JoshuaKGoldberg merged commit47f1ab3 intotypescript-eslint:main

Dec 7, 2024

56 of 58 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Dec 9, 2024

fix(deps): update typescript-eslint monorepo to v8.18.0

46e638c

##### [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09)##### 🚀 Features-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218))-   **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397))##### 🩹 Fixes-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436))-   **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432))-   **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374))-   typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   rtrittoYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Dec 10, 2024

Update typescript-eslint monorepo to v8.18.0

51f306c

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.17.0 | 8.18.0 || npm        | @typescript-eslint/parser        | 8.17.0 | 8.18.0 |## [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09)##### 🚀 Features-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218))-   **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397))##### 🩹 Fixes-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436))-   **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432))-   **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374))-   typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   rtrittoYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Dec 10, 2024

Update typescript-eslint monorepo to v8.18.0

0ec3b28

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.17.0 | 8.18.0 || npm        | @typescript-eslint/parser        | 8.17.0 | 8.18.0 |## [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09)##### 🚀 Features-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218))-   **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397))##### 🩹 Fixes-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436))-   **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432))-   **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374))-   typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   rtrittoYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 20, 2024

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

6 participants

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [switch-exhaustiveness-check] add support for "no default" comment#10218

feat(eslint-plugin): [switch-exhaustiveness-check] add support for "no default" comment#10218

Uh oh!

Conversation

developer-bandi commentedOct 27, 2024

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedOct 27, 2024

Uh oh!

netlifybot commentedOct 27, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedOct 27, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedOct 27, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

developer-bandi commentedOct 30, 2024

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FloEdelmannDec 4, 2024

Choose a reason for hiding this comment

Uh oh!

developer-bandiDec 7, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergDec 7, 2024

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlifybot commentedOct 27, 2024•
edited
Loading

nx-cloudbot commentedOct 27, 2024•
edited
Loading

codecovbot commentedOct 27, 2024•
edited
Loading

developer-bandiDec 7, 2024•
edited
Loading