Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(utils): allow an array for the values of SharedConfig#10217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@trygveaa
Copy link
Contributor

PR Checklist

Overview

According to the docs for ESLint an array should be allowed here, and the type used by ESLint in theirESLint.Plugin interface is:

Record<string, Linter.LegacyConfig | Linter.Config | Linter.Config[]> | undefined

So we should also allow an array. The helper functiontseslint.config returns an array so without this you're not allowed to use a config returned by this function as a value in this record.

Fixes#10213

💖

kirkwaiblinger and maks-rafalko reacted with heart emoji
According to the docs for ESLint an array should be allowed here, andthe type used by ESLint in their `ESLint.Plugin` interface is:    Record<string, Linter.LegacyConfig | Linter.Config | Linter.Config[]> | undefinedSo we should also allow an array. The helper function `tseslint.config`returns an array so without this you're not allowed to use a configreturned by this function as a value in this record.Fixestypescript-eslint#10213
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@trygveaa!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 27, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit013cc52
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/671e21b4a80f2600086aafde
😎 Deploy Previewhttps://deploy-preview-10217--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 93 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedOct 27, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit013cc52. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

@bradzacherbradzacher merged commit3f34490 intotypescript-eslint:mainNov 3, 2024
64 checks passed
@trygveaatrygveaa deleted the sharedconfigs-allow-array branchNovember 3, 2024 12:21
karlhorky added a commit to upleveled/eslint-config-upleveled that referenced this pull requestNov 8, 2024
renovatebot added a commit to upleveled/eslint-config-upleveled that referenced this pull requestNov 8, 2024
* Update dependency upgrades - non-major* Fix type error with new typescript-eslint change-typescript-eslint/typescript-eslint#10217---------Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Co-authored-by: Karl Horky <karl.horky@gmail.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Type for values of SharedConfigs should allow an array

2 participants

@trygveaa@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp