typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): [await-thenable] report unnecessary`await using` statements#10209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 6 commits intotypescript-eslint:mainfromkirkwaiblinger:await-thenable-await-using

Nov 4, 2024

Merged

feat(eslint-plugin): [await-thenable] report unnecessary`await using` statements#10209

JoshuaKGoldberg merged 6 commits intotypescript-eslint:mainfromkirkwaiblinger:await-thenable-await-using

Nov 4, 2024

Conversation

Copy link

Member

kirkwaiblinger commentedOct 26, 2024

PR Checklist

Addresses an existing open issue: fixes part ofEnhancement: [await-thenable] should prohibit using a sync disposable withawait using #10208
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Basically just checks whether the RHS of anawait using statementmight have a[Symbol.asyncDispose](), otherwise reports.

Added in docs and a couple minor refactors. Also modified thegetFixOrSuggest() method to allow providingno fix or suggestion.

[await-thenable] report unnecessary await using statements

806ac11

Copy link

Contributor

typescript-eslintbot commentedOct 26, 2024

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 26, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`dc463aa`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6728f84b5e8ecf0008cb013c
😎 Deploy Preview	https://deploy-preview-10209--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedOct 26, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitdc463aa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

kirkwaiblinger commented

Oct 26, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/await-thenable.test.tsShow resolvedHide resolved

continue, not return

660f810

Copy link

codecovbot commentedOct 26, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base(099fd4c) to head(dc463aa).
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10209      +/-   ##==========================================+ Coverage   86.51%   86.52%   +0.01%==========================================  Files         430      430                Lines       15098    15142      +44       Branches     4384     4405      +21     ==========================================+ Hits        13062    13102      +40- Misses       1679     1683       +4  Partials      357      357

Flag	Coverage Δ
unittest	`86.52% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/await-thenable.ts	`100.00% <100.00%> (ø)`
.../rules/prefer-optional-chain-utils/analyzeChain.ts	`100.00% <100.00%> (ø)`
packages/eslint-plugin/src/rules/return-await.ts	`97.43% <100.00%> (+0.02%)`	⬆️
packages/eslint-plugin/src/util/getFixOrSuggest.ts	`100.00% <100.00%> (ø)`

... and9 files with indirect coverage changes

kirkwaiblinger commented

Oct 26, 2024

View reviewed changes

packages/eslint-plugin/src/rules/await-thenable.ts OutdatedShow resolvedHide resolved

kirkwaiblinger mentioned this pull request

Oct 26, 2024

Enhancement: [await-thenable] should prohibit using a sync disposable withawait using#10208

Closed

4 tasks

await using without init

ea8339a

kirkwaiblinger marked this pull request as ready for review

October 27, 2024 07:08

kirkwaiblinger added2 commits

October 27, 2024 11:38

disable lint error

80f159c

Merge branch 'main' into await-thenable-await-using

969e09d

JoshuaKGoldberg requested changes

Nov 4, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Clever, I like how thegetFixOrSuggest change fits in!

Just requesting changes on the docs, WDYT?

packages/eslint-plugin/tests/docs.test.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/await-thenable.test.tsShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 4, 2024

exempt code ticks from upper-case heading test

dc463aa

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

JoshuaKGoldberg approved these changes

Nov 4, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🙌

JoshuaKGoldberg merged commit5b2ebcd intotypescript-eslint:main

Nov 4, 2024

60 of 62 checks passed

kirkwaiblinger deleted the await-thenable-await-using branch

November 4, 2024 22:33

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Nov 11, 2024

fix(deps): update typescript-eslint monorepo to v8.14.0

ffd7e61

##### [v8.14.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8140-2024-11-11)##### 🚀 Features-   **eslint-plugin:** \[await-thenable] report unnecessary `await using` statements ([#10209](typescript-eslint/typescript-eslint#10209))-   **eslint-plugin:** \[no-confusing-void-expression] add an option to ignore void<->void ([#10067](typescript-eslint/typescript-eslint#10067))##### 🩹 Fixes-   **scope-manager:** fix asserted increments not being marked as write references ([#10271](typescript-eslint/typescript-eslint#10271))-   **eslint-plugin:** \[no-misused-promises] improve report loc for methods ([#10216](typescript-eslint/typescript-eslint#10216))-   **eslint-plugin:** \[no-unnecessary-condition] improve error message for literal comparisons ([#10194](typescript-eslint/typescript-eslint#10194))##### ❤️  Thank You-   Gyumong [@gyumong](https://github.com/Gyumong)-   Jan Ochwat [@janek515](https://github.com/janek515)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 12, 2024

Update typescript-eslint monorepo to v8.14.0

da248fc

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.13.0 | 8.14.0 || npm        | @typescript-eslint/parser        | 8.13.0 | 8.14.0 |## [v8.14.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8140-2024-11-11)##### 🚀 Features-   **eslint-plugin:** \[await-thenable] report unnecessary `await using` statements ([#10209](typescript-eslint/typescript-eslint#10209))-   **eslint-plugin:** \[no-confusing-void-expression] add an option to ignore void<->void ([#10067](typescript-eslint/typescript-eslint#10067))##### 🩹 Fixes-   **scope-manager:** fix asserted increments not being marked as write references ([#10271](typescript-eslint/typescript-eslint#10271))-   **eslint-plugin:** \[no-misused-promises] improve report loc for methods ([#10216](typescript-eslint/typescript-eslint#10216))-   **eslint-plugin:** \[no-unnecessary-condition] improve error message for literal comparisons ([#10194](typescript-eslint/typescript-eslint#10194))##### ❤️  Thank You-   Gyumong [@gyumong](https://github.com/Gyumong)-   Jan Ochwat [@janek515](https://github.com/janek515)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 12, 2024

Update typescript-eslint monorepo to v8.14.0

d376526

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.13.0 | 8.14.0 || npm        | @typescript-eslint/parser        | 8.13.0 | 8.14.0 |## [v8.14.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8140-2024-11-11)##### 🚀 Features-   **eslint-plugin:** \[await-thenable] report unnecessary `await using` statements ([#10209](typescript-eslint/typescript-eslint#10209))-   **eslint-plugin:** \[no-confusing-void-expression] add an option to ignore void<->void ([#10067](typescript-eslint/typescript-eslint#10067))##### 🩹 Fixes-   **scope-manager:** fix asserted increments not being marked as write references ([#10271](typescript-eslint/typescript-eslint#10271))-   **eslint-plugin:** \[no-misused-promises] improve report loc for methods ([#10216](typescript-eslint/typescript-eslint#10216))-   **eslint-plugin:** \[no-unnecessary-condition] improve error message for literal comparisons ([#10194](typescript-eslint/typescript-eslint#10194))##### ❤️  Thank You-   Gyumong [@gyumong](https://github.com/Gyumong)-   Jan Ochwat [@janek515](https://github.com/janek515)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Nov 13, 2024

Labels

awaiting response

Issues waiting for a reply from the OP or another party

2 participants

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [await-thenable] report unnecessaryawait using statements#10209

feat(eslint-plugin): [await-thenable] report unnecessaryawait using statements#10209

Uh oh!

Conversation

kirkwaiblinger commentedOct 26, 2024

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedOct 26, 2024

Uh oh!

netlifybot commentedOct 26, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedOct 26, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

Uh oh!

codecovbot commentedOct 26, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat(eslint-plugin): [await-thenable] report unnecessary`await using` statements#10209

feat(eslint-plugin): [await-thenable] report unnecessary`await using` statements#10209

netlifybot commentedOct 26, 2024•
edited
Loading

nx-cloudbot commentedOct 26, 2024•
edited
Loading

codecovbot commentedOct 26, 2024•
edited
Loading