This adds a utility function to check for a falseyBigInt. I implemented functions to converttype.value to BigInt when necessary, yet this still required the extra condition incheckNode for the specific edge case.

peanutenthusiast added2 commits

October 23, 2024 11:33

Add unnecessary condition test for falsey big int

d66a79e

Add function to get big int from pseudo big int

159c5fb

Copy link

Contributor

typescript-eslintbot commentedOct 24, 2024

Thanks for the PR,@peanutenthusiast!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 24, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`264d312`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6723ac0ec2f69600089fd95c
😎 Deploy Preview	https://deploy-preview-10205--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedOct 24, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit264d312. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

peanutenthusiast changed the title~~Fix/10197/big falsey bigint should be always falsy~~fix(eslint-plugin): [no-unnecessary-condition] falsey bigint should be falsey

Oct 24, 2024

peanutenthusiast added2 commits

October 24, 2024 13:32

Remove semicolons from getValue function in no unnecessary condition,…

e9e6830

… change test format for falsey big int

Add utility function to check if type is falsey big int

c5e57ee

peanutenthusiast marked this pull request as ready for review

October 24, 2024 22:27

Copy link

codecovbot commentedOct 24, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.51%. Comparing base(beba27a) to head(3cc6ae6).
Report is 1 commits behind head on main.

❗Current head3cc6ae6 differs from pull request most recent head264d312
Pleaseupload reports for the commit264d312 to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10205   +/-   ##=======================================  Coverage   86.50%   86.51%           =======================================  Files         430      430             Lines       15088    15098   +10       Branches     4380     4384    +4     =======================================+ Hits        13052    13062   +10  Misses       1679     1679             Partials      357      357

Flag	Coverage Δ
unittest	`86.51% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts	`99.13% <100.00%> (+0.03%)`	⬆️

kirkwaiblinger requested changes

Oct 27, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good stuff, thanks for sending this in!

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts Outdated

		@@ -306,6 +326,8 @@ export default createRule<Options, MessageId>({
		messageId = !isUnaryNotArgument ? 'alwaysFalsy' : 'alwaysTruthy';
		} else if (!isPossiblyFalsy(type)) {
		messageId = !isUnaryNotArgument ? 'alwaysTruthy' : 'alwaysFalsy';
		} else if (isFalseyBigInt(type)) {

Copy link

Member

kirkwaiblingerOct 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oh, fun. This line "shouldn't" be necessary, since for0n,!isPossiblyTruthy(type)should betrue, since ts-api-utils'sisFalsyType(type)should betrue. But it's not, since ts-api-utils has the exact same bug that was in this rule!

https://github.com/JoshuaKGoldberg/ts-api-utils/blob/41cd21d41f445448681dd32308a48a004f4717cb/src/types/utilities.ts#L50

FiledJoshuaKGoldberg/ts-api-utils#544 to get that corrected. I'd say - let's move this workaround to theisPossiblyTruthy function instead just after theisFalsyType(type) check, and put a note that this is a workaround for the ts-api-utils bug

Copy link

ContributorAuthor

peanutenthusiastOct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lines 75-77 implement the suggested change and note.

peanutenthusiastand others added2 commits

October 27, 2024 14:13

Remove check for base10Value in valueIsPseudoBigInt

4a858e6

Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>

Add isFalseyBigInt invocation to isPossibly truthy for ts api utils w…

986e138

…ork around

peanutenthusiast requested a review fromkirkwaiblinger

October 28, 2024 20:22

kirkwaiblinger requested changes

Oct 30, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unnecessary-condition.tsShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts OutdatedShow resolvedHide resolved

peanutenthusiastand others added3 commits

October 30, 2024 12:28

Add test cases for positive and negative bigint values

ac06300

Update packages/eslint-plugin/src/rules/no-unnecessary-condition.ts

ee0544f

Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>

Add valid test case for bigint: 0n | 1n

4819d64

Josh-Cena reviewed

Oct 31, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts OutdatedShow resolvedHide resolved

peanutenthusiastand others added3 commits

October 31, 2024 08:16

Update packages/eslint-plugin/src/rules/no-unnecessary-condition.ts

d916627

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>

Fix isFalsyBigInt invocation

3cc6ae6

Merge branch 'main' into fix/10197/big-falsey-bigint-should-be-always…

264d312

…-falsy

kirkwaiblinger approved these changes

Oct 31, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger commentedOct 31, 2024

Looks great to me! Thank you for doing this, and handling some pretty surprising edge cases!

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Oct 31, 2024

kirkwaiblinger requested a review fromJosh-Cena

October 31, 2024 17:43

github-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Oct 31, 2024

Josh-Cena approved these changes

Oct 31, 2024

View reviewed changes

kirkwaiblinger merged commit964fa91 intotypescript-eslint:main

Oct 31, 2024

61 of 63 checks passed

kirkwaiblinger mentioned this pull request

Oct 31, 2024

fix(eslint-plugin): [no-unnecessary-condition] improve error message for literal comparisons#10194

Merged

3 tasks

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Nov 4, 2024

fix(deps): update typescript-eslint monorepo to v8.13.0

36eca14

##### [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 6, 2024

Update typescript-eslint monorepo to v8.13.0

12a50df

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.12.2 | 8.13.0 || npm        | @typescript-eslint/parser        | 8.12.2 | 8.13.0 |## [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 7, 2024

Update typescript-eslint monorepo to v8.13.0

486fea9

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.12.2 | 8.13.0 || npm        | @typescript-eslint/parser        | 8.12.2 | 8.13.0 |## [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Nov 8, 2024

Labels

None yet

3 participants

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-unnecessary-condition] falsey bigint should be falsey#10205

fix(eslint-plugin): [no-unnecessary-condition] falsey bigint should be falsey#10205

Uh oh!

Conversation

peanutenthusiast commentedOct 24, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedOct 24, 2024

Uh oh!

netlifybot commentedOct 24, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedOct 24, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedOct 24, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kirkwaiblingerOct 27, 2024

Choose a reason for hiding this comment

Uh oh!

peanutenthusiastOct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger commentedOct 31, 2024

Uh oh!

Uh oh!

Uh oh!

peanutenthusiast commentedOct 24, 2024•
edited
Loading

netlifybot commentedOct 24, 2024•
edited
Loading

nx-cloudbot commentedOct 24, 2024•
edited
Loading

codecovbot commentedOct 24, 2024•
edited
Loading