fix(eslint-plugin): improve detection of used vars in heritage#102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JamesHenry merged 2 commits intotypescript-eslint:masterfromarmano2:no-unused-vars

Jan 21, 2019

Merged

fix(eslint-plugin): improve detection of used vars in heritage#102

JamesHenry merged 2 commits intotypescript-eslint:masterfromarmano2:no-unused-vars

Jan 21, 2019

Conversation

Copy link

Collaborator

armano2 commentedJan 21, 2019

This PR fixes issue with heritage clause in classes and interfaces, it also reduces possible false possitives from class heritage when used as MemberExpression

fixes:#45

armano2 added2 commits

January 21, 2019 06:45

fix(eslint-plugin): improve detection of used vars in heritage

7ba022f

chore(eslint-plugin): linting errors

158721a

Copy link

codecovbot commentedJan 21, 2019

Codecov Report

Merging#102 intomaster willincrease coverage by0.02%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #102      +/-   ##==========================================+ Coverage   94.81%   94.83%   +0.02%==========================================  Files          48       48                Lines        2470     2480      +10       Branches      381      381              ==========================================+ Hits         2342     2352      +10  Misses         77       77                Partials       51       51

Impacted Files	Coverage Δ
packages/eslint-plugin/lib/rules/no-unused-vars.js	`100% <100%> (ø)`	⬆️

JamesHenry approved these changes

Jan 21, 2019

View reviewed changes

JamesHenry merged commit193b434 intotypescript-eslint:master

Jan 21, 2019

armano2 deleted the no-unused-vars branch

January 21, 2019 15:49

This was referencedJan 21, 2019

port linting to use renamed TS parserdesktop/desktop#6684

Merged

[Question] why the redundant rules?#122

Closed

armanio123 pushed a commit to armanio123/typescript-eslint that referenced this pull request

Jan 24, 2019

Update: explicit-member-accessibility only check *.ts and *.tsx files (…

5ed8a4a

…Fixestypescript-eslint#102) (typescript-eslint#104)* Only check *.ts and *.tsx files (Fixestypescript-eslint#102)* Move duplicated isTypescript() function to util.js* Simplify regex in isTypescript()