chore: switch from explicit-function-return-type to explicit-module-boundary-types internally#10193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromJoshuaKGoldberg:internal-efrt-to-embt

Oct 27, 2024

Merged

chore: switch from explicit-function-return-type to explicit-module-boundary-types internally#10193

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromJoshuaKGoldberg:internal-efrt-to-embt

Oct 27, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedOct 22, 2024

PR Checklist

Addresses an existing open issue:fixesRepo: Switch from explicit-function-return-type to isolatedDeclarations and/or explicit-module-boundary-type #9419
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Purely switches the ESLint config and some necessary inline comments. Doesn't attempt to remove existing annotations.

💖

chore: switch from explicit-function-return-type to explicit-module-b…

85d93c3

…oundary-types internally

Copy link

Contributor

typescript-eslintbot commentedOct 22, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 22, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`85d93c3`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6716fd18ae45e900085e4308
😎 Deploy Preview	https://deploy-preview-10193--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedOct 22, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit85d93c3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.