Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(eslint-plugin): added related-getter-setter-pairs rule#10192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(eslint-plugin): added related-getter-setter-pairs rule#10192
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedOct 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
nx-cloudbot commentedOct 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
☁️ Nx Cloud ReportCI is running/has finished running commands for commite76d87b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 fromNxCloud. |
6b00bee to5e9817fCompare| allowNullish: false, | ||
| allowNumber: false, | ||
| allowRegExp: false, | ||
| allowNever: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🤷
Uh oh!
There was an error while loading.Please reload this page.
packages/eslint-plugin/tests/rules/related-getter-setter-pairs.test.ts OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
codecovbot commentedNov 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #10192 +/- ##==========================================+ Coverage 86.07% 86.59% +0.51%========================================== Files 428 432 +4 Lines 14939 15216 +277 Branches 4333 4423 +90 ==========================================+ Hits 12859 13176 +317+ Misses 1735 1683 -52- Partials 345 357 +12
Flags with carried forward coverage won't be shown.Click here to find out more.
|
packages/eslint-plugin/docs/rules/related-getter-setter-pairs.mdx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks right to me! 🙂
0409851 intotypescript-eslint:mainUh oh!
There was an error while loading.Please reload this page.
…pt-eslint#10192)* feat(eslint-plugin): added related-getter-setter-pairs rule* Fixed stack popping* Fixed stack popping* Correction: reported getter always has return type annotation* Correction: reported getter always has return type annotation* Update packages/eslint-plugin/docs/rules/related-getter-setter-pairs.mdxCo-authored-by: Joshua Chen <sidachen2003@gmail.com>---------Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
##### [v8.15.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8150-2024-11-18)##### 🚀 Features- **eslint-plugin:** \[prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator ([#10299](typescript-eslint/typescript-eslint#10299))- **eslint-plugin:** new rule `no-unsafe-type-assertion` ([#10051](typescript-eslint/typescript-eslint#10051))- **eslint-plugin:** added related-getter-setter-pairs rule ([#10192](typescript-eslint/typescript-eslint#10192))##### 🩹 Fixes- **utils:** add defaultOptions to meta in rule ([#10339](typescript-eslint/typescript-eslint#10339))- **eslint-plugin:** report deprecations used in default export ([#10330](typescript-eslint/typescript-eslint#10330))- **eslint-plugin:** \[explicit-module-boundary-types] and \[explicit-function-return-type] don't report on `as const satisfies` ([#10315](typescript-eslint/typescript-eslint#10315))- **eslint-plugin:** \[await-thenable, return-await] don't flag awaiting unconstrained type parameter as unnecessary ([#10314](typescript-eslint/typescript-eslint#10314))- **eslint-plugin:** \[consistent-indexed-object-style] handle circular mapped types ([#10301](typescript-eslint/typescript-eslint#10301))##### ❤️ Thank You- Josh Goldberg ✨- Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)- Luis Sebastian Urrutia Fuentes [@LuisUrrutia](https://github.com/LuisUrrutia)- Phillip Huang- Ronen Amiel- Szydlak [@wszydlak](https://github.com/wszydlak)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
PR Checklist
Overview
💖