typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

chore: enable eslint-plugin-perfectionist on the rest of the repo#10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 6 commits intotypescript-eslint:mainfromJoshuaKGoldberg:perfectionist-remaining

Nov 4, 2024

Merged

chore: enable eslint-plugin-perfectionist on the rest of the repo#10189

JoshuaKGoldberg merged 6 commits intotypescript-eslint:mainfromJoshuaKGoldberg:perfectionist-remaining

Nov 4, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedOct 21, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesRepo: Enable alphabetical (natural) sorting of fields #8479
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Completely replaces thesimple-import-sort plugin withperfectionist, and enables it as a baseline in all remaining files.

💖

chore: enable eslint-plugin-perfectionist on the rest of the repo

d0b77a0

Copy link

Contributor

typescript-eslintbot commentedOct 21, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 21, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`5cab80b`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6728d332f0924e00084f76d2
😎 Deploy Preview	https://deploy-preview-10189--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedOct 21, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5cab80b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedOct 21, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base(3664c20) to head(5cab80b).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10189   +/-   ##=======================================  Coverage   86.50%   86.50%           =======================================  Files         430      430             Lines       15118    15121    +3       Branches     4396     4397    +1     =======================================+ Hits        13078    13081    +3  Misses       1683     1683             Partials      357      357

Flag	Coverage Δ
unittest	`86.50% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts	`95.45% <ø> (ø)`
...rc/rules/no-relative-paths-to-internal-packages.ts	`100.00% <ø> (ø)`
...internal/src/rules/no-typescript-default-import.ts	`86.66% <ø> (ø)`
...-internal/src/rules/no-typescript-estree-import.ts	`87.50% <ø> (ø)`
...lugin-internal/src/rules/plugin-test-formatting.ts	`82.79% <ø> (ø)`
...plugin-internal/src/rules/prefer-ast-types-enum.ts	`100.00% <100.00%> (ø)`
packages/scope-manager/src/lib/es2015.core.ts	`100.00% <ø> (ø)`
packages/scope-manager/src/lib/es2015.iterable.ts	`100.00% <ø> (ø)`
...s/scope-manager/src/lib/es2015.symbol.wellknown.ts	`100.00% <ø> (ø)`
packages/scope-manager/src/lib/es2015.ts	`100.00% <100.00%> (ø)`
... and7 more