Allowing custom filenames outside the current directory inRuleTester.
Fix is similar to the one in ESLintfix: handle absoulte file paths in RuleTester #17989.
Since we cannot directly useFlatConfigArray, I mock it with an Object containing abasePath property.

fix(rule-tester): allow custom filename outside directory

35aaeb7

Copy link

Contributor

typescript-eslintbot commentedOct 14, 2024

Thanks for the PR,@lotmek!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 14, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`35aaeb7`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/670d95cd2d41ba0008cc122e
😎 Deploy Preview	https://deploy-preview-10147--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedOct 14, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit35aaeb7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedOct 14, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is66.66667% with1 line in your changes missing coverage. Please review.

Project coverage is 86.17%. Comparing base(f153eb1) to head(35aaeb7).
Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/rule-tester/src/RuleTester.ts	66.66%	0 Missing and 1 partial⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10147      +/-   ##==========================================- Coverage   86.18%   86.17%   -0.01%==========================================  Files         428      428                Lines       14981    14983       +2       Branches     4344     4345       +1     ==========================================+ Hits        12911    12912       +1  Misses       1724     1724- Partials      346      347       +1

Flag	Coverage Δ
unittest	`86.17% <66.66%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/rule-tester/src/RuleTester.ts	`63.31% <66.66%> (-0.07%)`	⬇️

JoshuaKGoldberg approved these changes

Oct 15, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice workaround! ✨

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Oct 15, 2024

kirkwaiblinger approved these changes

Oct 15, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hugely appreciate this!♥️

JoshuaKGoldberg merged commit70a381d intotypescript-eslint:main

Oct 21, 2024

73 of 74 checks passed

Copy link

AviVahl commentedOct 21, 2024

I believe we see a regression with this patch downstream:

TypeError: Cannot read properties of undefined (reading 'parse')      at ParserService.parseSync (/home/avi/projects/stylable/node_modules/eslint/lib/services/parser-service.js:36:33)      at #flatVerifyWithoutProcessors (/home/avi/projects/stylable/node_modules/eslint/lib/linter/linter.js:1680:47)      at Linter._verifyWithFlatConfigArrayAndWithoutProcessors (/home/avi/projects/stylable/node_modules/eslint/lib/linter/linter.js:1992:49)      at Linter._verifyWithFlatConfigArray (/home/avi/projects/stylable/node_modules/eslint/lib/linter/linter.js:2081:21)      at Linter.verify (/home/avi/projects/stylable/node_modules/eslint/lib/linter/linter.js:1528:61)      at Linter.RuleTester.#linter.linter.verify (/home/avi/projects/stylable/node_modules/@typescript-eslint/rule-tester/src/RuleTester.ts:202:18)      at RuleTester.runRuleForItem (/home/avi/projects/stylable/node_modules/@typescript-eslint/rule-tester/src/RuleTester.ts:770:33)      at RuleTester.#testValidTemplate (/home/avi/projects/stylable/node_modules/@typescript-eslint/rule-tester/src/RuleTester.ts:863:25)      at Context.<anonymous> (/home/avi/projects/stylable/node_modules/@typescript-eslint/rule-tester/src/RuleTester.ts:541:40)