typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString#10138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 13 commits intotypescript-eslint:mainfromy-hsgw:feature/no-base-to-string-to-locale-string

Oct 21, 2024

Merged

feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString#10138

JoshuaKGoldberg merged 13 commits intotypescript-eslint:mainfromy-hsgw:feature/no-base-to-string-to-locale-string

Oct 21, 2024

Conversation

Copy link

Contributor

y-hsgw commentedOct 12, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixes[no-base-to-string] doesn't catch toLocaleString #2440
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR adds support for catching the toLocaleString() method.

🚀

y-hsgw added4 commits

October 12, 2024 20:01

feat: add support for toLocaleString method

00754ea

test: add Tests

6ef7066

test: fix test

3e4bcff

docs: update doc

c246f0a

Copy link

Contributor

typescript-eslintbot commentedOct 12, 2024

Thanks for the PR,@y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 12, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`49de003`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6716628c741f3100089e1a88
😎 Deploy Preview	https://deploy-preview-10138--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedOct 12, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit49de003. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

y-hsgw changed the title~~feat(eslint-plugin): [no-base-to-string]add support for catching toLocaleString~~feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString

Oct 12, 2024

test: update snapshot and fix description

f37af6a

Copy link

codecovbot commentedOct 12, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base(ba12b14) to head(49de003).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10138   +/-   ##=======================================  Coverage   86.14%   86.14%           =======================================  Files         430      430             Lines       15009    15009             Branches     4354     4355    +1     =======================================  Hits        12930    12930             Misses       1729     1729             Partials      350      350

Flag	Coverage Δ
unittest	`86.14% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`95.16% <100.00%> (ø)`

JoshuaKGoldberg reviewed

Oct 14, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdx OutdatedShow resolvedHide resolved

docs: fix typo

ebc6947

kirkwaiblinger previously approved these changes

Oct 14, 2024

View reviewed changes

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Oct 14, 2024

JoshuaKGoldberg approved these changes

Oct 15, 2024

View reviewed changes

JoshuaKGoldberg reviewed

Oct 15, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg requested changes

Oct 15, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oop, sorry, almost missed - some test requests?

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts OutdatedShow resolvedHide resolved

test: fix typo and remove test

31a7cf4

FloEdelmann suggested changes

Oct 15, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdx OutdatedShow resolvedHide resolved

Update packages/eslint-plugin/docs/rules/no-base-to-string.mdx

3ffe462

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

y-hsgw dismissedkirkwaiblinger’sstale review via3ffe462

October 15, 2024 10:20

y-hsgwand others added2 commits

October 15, 2024 19:20

Update packages/eslint-plugin/docs/rules/no-base-to-string.mdx

1c49fd6

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

Merge branch 'feature/no-base-to-string-to-locale-string' ofhttps://…

ea11e91

…github.com/y-hsgw/typescript-eslint into feature/no-base-to-string-to-locale-string

y-hsgw requested review fromJoshuaKGoldberg andFloEdelmann

October 15, 2024 10:25

github-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Oct 15, 2024

JoshuaKGoldberg approved these changes

Oct 15, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Getting there 🙂 only small things from me.

packages/eslint-plugin/docs/rules/no-base-to-string.mdx OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg requested changes

Oct 15, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(wrong button)

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 15, 2024

no-base-to-string.mdx を更新

379dba6

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

Update packages/eslint-plugin/tests/rules/no-base-to-string.test.ts

b4c7216

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

y-hsgw requested a review fromJoshuaKGoldberg

October 15, 2024 14:46

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 15, 2024

JoshuaKGoldberg previously approved these changes

Oct 15, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Oct 15, 2024

Merge branch 'main'

49de003

JoshuaKGoldberg dismissed theirstale review via49de003

October 21, 2024 14:17

JoshuaKGoldberg merged commit9a182d0 intotypescript-eslint:main

Oct 21, 2024

60 checks passed

y-hsgw deleted the feature/no-base-to-string-to-locale-string branch

October 21, 2024 15:44

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Oct 21, 2024

fix(deps): update typescript-eslint monorepo to v8.11.0

c33cb3e

##### [v8.11.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8110-2024-10-21)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-type-parameters] add suggestion fixer ([#10149](typescript-eslint/typescript-eslint#10149))-   **eslint-plugin:** \[no-base-to-string] add support for catching toLocaleString ([#10138](typescript-eslint/typescript-eslint#10138))##### 🩹 Fixes-   **eslint-plugin:** \[class-literal-property-style] don't report nodes with `override` keyword ([#10135](typescript-eslint/typescript-eslint#10135))##### ❤️  Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Oct 22, 2024

Update typescript-eslint monorepo to v8.11.0

57b817d

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.10.0 | 8.11.0 || npm        | @typescript-eslint/parser        | 8.10.0 | 8.11.0 |## [v8.11.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8110-2024-10-21)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-type-parameters] add suggestion fixer ([#10149](typescript-eslint/typescript-eslint#10149))-   **eslint-plugin:** \[no-base-to-string] add support for catching toLocaleString ([#10138](typescript-eslint/typescript-eslint#10138))##### 🩹 Fixes-   **eslint-plugin:** \[class-literal-property-style] don't report nodes with `override` keyword ([#10135](typescript-eslint/typescript-eslint#10135))##### ❤️  Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Oct 22, 2024

Update typescript-eslint monorepo to v8.11.0

d0cc95e

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.10.0 | 8.11.0 || npm        | @typescript-eslint/parser        | 8.10.0 | 8.11.0 |## [v8.11.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8110-2024-10-21)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-type-parameters] add suggestion fixer ([#10149](typescript-eslint/typescript-eslint#10149))-   **eslint-plugin:** \[no-base-to-string] add support for catching toLocaleString ([#10138](typescript-eslint/typescript-eslint#10138))##### 🩹 Fixes-   **eslint-plugin:** \[class-literal-property-style] don't report nodes with `override` keyword ([#10135](typescript-eslint/typescript-eslint#10135))##### ❤️  Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Oct 29, 2024

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

4 participants

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString#10138

feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString#10138

Uh oh!

Conversation

y-hsgw commentedOct 12, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedOct 12, 2024

Uh oh!

netlifybot commentedOct 12, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedOct 12, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedOct 12, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

y-hsgw commentedOct 12, 2024•
edited
Loading

netlifybot commentedOct 12, 2024•
edited
Loading

nx-cloudbot commentedOct 12, 2024•
edited
Loading

codecovbot commentedOct 12, 2024•
edited
Loading