Oct 18, 2024 · Oct 11, 2024
diff --git a/packages/eslint-plugin/src/rules/class-literal-property-style.ts b/packages/eslint-plugin/src/rules/class-literal-property-style.ts
        MethodDefinition(node): void {
          if (
            node.kind !== 'get' ||
            node.override ||
            !node.value.body ||
            node.value.body.body.length === 0
          ) {
          }
        },
        PropertyDefinition(node): void {
          if (!node.readonly || node.declare) {
          if (!node.readonly || node.declare || node.override) {
            return;
          }
          const { properties } =
diff --git a/packages/eslint-plugin/tests/rules/class-literal-property-style.test.ts b/packages/eslint-plugin/tests/rules/class-literal-property-style.test.ts
      `,
      options: ['getters'],
    },
    {
      // https://github.com/typescript-eslint/typescript-eslint/issues/3602
      // getter with override modifier should be ignored
      code: `
 declare abstract class BaseClass {
  get cursor(): string;
 }

 class ChildClass extends BaseClass {
  override get cursor() {
    return 'overridden value';
  }
 }
      `,
    },
    {
      // https://github.com/typescript-eslint/typescript-eslint/issues/3602
      // property with override modifier should be ignored
      code: `
 declare abstract class BaseClass {
  protected readonly foo: string;
 }

 class ChildClass extends BaseClass {
  protected override readonly foo = 'bar';
 }
      `,
      options: ['getters'],
    },
  ],
  invalid: [
    {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -145,6 +145,7 @@ export default createRule<Options, MessageIds>({
		MethodDefinition(node): void {
		if (
		node.kind !== 'get' \|\|
		node.override \|\|
		!node.value.body \|\|
		node.value.body.body.length === 0
		) {
Expand DownExpand Up		@@ -222,7 +223,7 @@ export default createRule<Options, MessageIds>({
		}
		},
		PropertyDefinition(node): void {
		if (!node.readonly \|\| node.declare) {
		if (!node.readonly \|\| node.declare \|\| node.override) {
		return;
		}
		const { properties } =
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -257,6 +257,35 @@ class Mx {
		`,
		options: ['getters'],
		},
		{
		// https://github.com/typescript-eslint/typescript-eslint/issues/3602
		// getter with override modifier should be ignored
		code: `
		declare abstract class BaseClass {
		get cursor(): string;
		}

		class ChildClass extends BaseClass {
		override get cursor() {
		return 'overridden value';
		}
		}
		`,
		},
		{
		// https://github.com/typescript-eslint/typescript-eslint/issues/3602
		// property with override modifier should be ignored
		code: `
		declare abstract class BaseClass {
		protected readonly foo: string;
		}

		class ChildClass extends BaseClass {
		protected override readonly foo = 'bar';
		}
		`,
		options: ['getters'],
		},
		],
		invalid: [
		{
Expand Down