Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): handle unions in await...for#10110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

lotmek
Copy link
Contributor

@lotmeklotmek commentedOct 6, 2024•
edited
Loading

PR Checklist

Overview

Handle Union types in in the for-statement of theawait-thenable rule.
If type is Union, we loop through each types to check if it contains an async Iterator.
If that's the case, we don't report an error.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@lotmek!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedOct 6, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitee78536
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67040f54eff9d20008ff7fa0
😎 Deploy Previewhttps://deploy-preview-10110--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 100 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedOct 6, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitee78536. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

@lotmeklotmek changed the titlefix(eslint-plugin): Handle unions in await...forfix(eslint-plugin): handle unions in await...forOct 6, 2024
@codecovCodecov
Copy link

codecovbot commentedOct 6, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base(e4e8f4e) to head(ee78536).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10110   +/-   ##=======================================  Coverage   86.07%   86.07%           =======================================  Files         428      428             Lines       14935    14937    +2       Branches     4331     4331           =======================================+ Hits        12855    12857    +2  Misses       1735     1735             Partials      345      345
FlagCoverage Δ
unittest86.07% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/await-thenable.ts100.00% <100.00%> (ø)

Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A couple little nits but looks great!

@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 7, 2024
kirkwaiblinger
kirkwaiblinger previously approved these changesOct 7, 2024
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Feel free to tweak the style comments still, but this is great. Thanks!

congratulatory meme

lotmek reacted with heart emoji
@github-actionsgithub-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 7, 2024
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 7, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commitef8642b intotypescript-eslint:mainOct 13, 2024
65 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 21, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@Thompson1985Thompson1985Thompson1985 approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: await-thenable doesn't handle unions cleanly in for-await [8.8.0 regression]
4 participants
@lotmek@kirkwaiblinger@Thompson1985@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp