Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): correct use-at-your-own-risk type definitions#10049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

Before:

tseslint-eslint-plugin-before

After:

tseslint-eslint-plugin-after

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 24, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit7c0eb39
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6709164c1ca44f00085c5e0f
😎 Deploy Previewhttps://deploy-preview-10049--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 24, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit7c0eb39. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 28 targets

Sent with 💌 fromNxCloud.

@aryaemami59aryaemami59force-pushed thefix-eslint-plugin-type-defs branch from3d23a04 to6355532CompareSeptember 25, 2024 18:06
@codecovCodecov
Copy link

codecovbot commentedSep 25, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.09%. Comparing base(974d9ce) to head(7c0eb39).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10049   +/-   ##=======================================  Coverage   86.09%   86.09%           =======================================  Files         428      428             Lines       14969    14969             Branches     4343     4343           =======================================  Hits        12888    12888             Misses       1734     1734             Partials      347      347
FlagCoverage Δ
unittest86.09% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

@aryaemami59aryaemami59force-pushed thefix-eslint-plugin-type-defs branch 2 times, most recently froma1deb84 to3cb5572CompareOctober 8, 2024 00:10
@aryaemami59aryaemami59force-pushed thefix-eslint-plugin-type-defs branch from3cb5572 toe9be1e0CompareOctober 10, 2024 02:42
@aryaemami59aryaemami59 marked this pull request as ready for reviewOctober 10, 2024 03:13
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): correct the type definitionsfix(eslint-plugin): correct use-at-your-own-risk type definitionsOct 10, 2024
@aryaemami59aryaemami59force-pushed thefix-eslint-plugin-type-defs branch frome9be1e0 tof58a74dCompareOctober 11, 2024 07:08
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Everything looks good.
Just need to removetypesVersions then we're good to go!

@bradzacherbradzacher added the awaiting responseIssues waiting for a reply from the OP or another party labelOct 11, 2024
@aryaemami59aryaemami59force-pushed thefix-eslint-plugin-type-defs branch fromf58a74d to7b9559cCompareOctober 11, 2024 12:09
@aryaemami59aryaemami59force-pushed thefix-eslint-plugin-type-defs branch from7b9559c to7c0eb39CompareOctober 11, 2024 12:12
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelOct 11, 2024
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

brilliant - thanks for your work on this!

aryaemami59 reacted with thumbs up emoji
@bradzacherbradzacher merged commit60f0766 intotypescript-eslint:mainOct 11, 2024
64 checks passed
@aryaemami59aryaemami59 deleted the fix-eslint-plugin-type-defs branchOctober 11, 2024 13:04
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: type definitions for use-at-your-own-risk/eslint-recommended-raw are missing
2 participants
@aryaemami59@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp