Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-unnecessary-template-expression] should underline template syntax with squiggly lines#10044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ronami
Copy link
Member

@ronamironami commentedSep 23, 2024•
edited
Loading

PR Checklist

Overview

This PR addresses#8597 and changes the squiggles marked by@typescript-eslint/no-unnecessary-template-expression from the following:

`use${'less'}template${'expressions'}`^^^^^^^^^^^^^^^^^^^

To also include the template syntax instead:

`use${'less'}template${'expressions'}`^^^^^^^^^^^^^^^^^^^^^^^^^

kirkwaiblinger reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 23, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf5e5d89
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66f43fa013bd630008c29ae9
😎 Deploy Previewhttps://deploy-preview-10044--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 94 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 23, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf5e5d89. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

@ronamironami changed the titleFixno-unnecessary-template-expression to include template syntax with squiggly linesfix(eslint-plugin):no-unnecessary-template-expression to include template syntax with squiggly linesSep 23, 2024
@ronamironami changed the titlefix(eslint-plugin):no-unnecessary-template-expression to include template syntax with squiggly linesfix(eslint-plugin):no-unnecessary-template-expression should underline template syntax with squiggly linesSep 23, 2024
@ronamironami changed the titlefix(eslint-plugin):no-unnecessary-template-expression should underline template syntax with squiggly linesfix(eslint-plugin): ruleno-unnecessary-template-expression should underline template syntax with squiggly linesSep 23, 2024
@ronamironami marked this pull request as ready for reviewSeptember 23, 2024 17:07
@codecovCodecov
Copy link

codecovbot commentedSep 23, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base(b6f4b2f) to head(f5e5d89).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10044   +/-   ##=======================================  Coverage   88.73%   88.74%           =======================================  Files         426      427    +1       Lines       14881    14886    +5       Branches     4327     4327           =======================================+ Hits        13205    13210    +5  Misses       1534     1534             Partials      142      142
FlagCoverage Δ
unittest88.74% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...-plugin/src/rules/explicit-member-accessibility.ts100.00% <100.00%> (ø)
...in/src/rules/no-unnecessary-template-expression.ts100.00% <100.00%> (ø)
packages/eslint-plugin/src/util/rangeToLoc.ts100.00% <100.00%> (ø)

@kirkwaiblingerkirkwaiblinger changed the titlefix(eslint-plugin): ruleno-unnecessary-template-expression should underline template syntax with squiggly linesfix(eslint-plugin): [no-unnecessary-template-expression] should underline template syntax with squiggly linesSep 23, 2024
kirkwaiblinger
kirkwaiblinger previously approved these changesSep 23, 2024
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lovely! And congrats on your first time contributing a PR to typescript-eslint ❤️

thumbs up gif

JoshuaKGoldberg and ronami reacted with heart emoji
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 23, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesSep 23, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ditto 😄

ronami reacted with heart emoji
…ssion.tsCo-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
…ssion.tsCo-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@kirkwaiblingerkirkwaiblinger merged commit6dbf234 intotypescript-eslint:mainSep 25, 2024
58 of 60 checks passed
@ronamironami deleted the no-unnecessary-template-expression-fix-squiggly-location branchSeptember 25, 2024 17:10
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@auvredauvredauvred approved these changes

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-template-expression] Report squigglies should underline template syntax, not just expression inside
4 participants
@ronami@JoshuaKGoldberg@kirkwaiblinger@auvred
[8]ページ先頭
©2009-2025 Movatter.jp