typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(type-utils): check for type parameters on`isBuiltinSymbolLikeRecurser()`#10026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromronami:check-type-parameter-is-builtin-symbol-like-recurser

Sep 27, 2024

Merged

fix(type-utils): check for type parameters on`isBuiltinSymbolLikeRecurser()`#10026

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromronami:check-type-parameter-is-builtin-symbol-like-recurser

Sep 27, 2024

Conversation

Copy link

Member

ronami commentedSep 20, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: @typescript-eslint/only-throw-error False positive when throwing Error subclass #9882
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR addresses#9882 along with a similar issue for@typescript-eslint/prefer-promise-reject-errors:

//@typescript-eslint/only-throw-errorfunctionfun1<TextendsError>(t:T):void{throwt;}//@typescript-eslint/prefer-promise-reject-errorsfunctionfun2<TextendsError>(t:T):void{Promise.reject(t);}

Since this changes a function that's being used in a lot of other places (isBuiltinSymbolLikeRecurser()), this can affect other rules (for better or worse).

Please let me know if you think this isn't the correct way to approach this.

Copy link

Contributor

typescript-eslintbot commentedSep 20, 2024

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 20, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`3406cb7`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66f116d9088d77000868211b
😎 Deploy Preview	https://deploy-preview-10026--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedSep 20, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3406cb7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

ronami changed the title~~Check for type parameters onisBuiltinSymbolLikeRecurser()~~fix(type-utils): Check for type parameters onisBuiltinSymbolLikeRecurser()

Sep 20, 2024

ronami changed the title~~fix(type-utils): Check for type parameters onisBuiltinSymbolLikeRecurser()~~fix(type-utils): check for type parameters onisBuiltinSymbolLikeRecurser()

Sep 20, 2024

Copy link

codecovbot commentedSep 20, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is16.66667% with5 lines in your changes missing coverage. Please review.

Project coverage is 88.67%. Comparing base(c5dc755) to head(3406cb7).
Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/type-utils/src/builtinSymbolLikes.ts	16.66%	5 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10026      +/-   ##==========================================- Coverage   88.70%   88.67%   -0.03%==========================================  Files         426      426                Lines       14835    14841       +6       Branches     4312     4314       +2     ==========================================+ Hits        13159    13160       +1- Misses       1533     1538       +5  Partials      143      143