Simply check forFunction type in existing rule.
Minor cleanup of some sloppiness in the report messages, to ensure that they can say "Function typed" rather than "any typed"

[no-unsafe-call] check calls of Function

6a7c1a6

Copy link

Contributor

typescript-eslintbot commentedSep 18, 2024

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 18, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`d1e954c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66eae80754c5600008adfe22
😎 Deploy Preview	https://deploy-preview-10010--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedSep 18, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd1e954c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

lint

9e8d854

kirkwaiblinger marked this pull request as ready for review

September 18, 2024 04:23

Copy link

codecovbot commentedSep 18, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is92.85714% with1 line in your changes missing coverage. Please review.

Project coverage is 88.70%. Comparing base(385bedb) to head(d1e954c).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/eslint-plugin/src/rules/no-unsafe-call.ts	92.85%	1 Missing⚠️

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10010   +/-   ##=======================================  Coverage   88.69%   88.70%           =======================================  Files         426      426             Lines       14829    14843   +14       Branches     4313     4318    +5     =======================================+ Hits        13153    13166   +13- Misses       1533     1534    +1  Partials      143      143

Flag	Coverage Δ
unittest	`88.70% <92.85%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-unsafe-call.ts	`97.05% <92.85%> (-2.95%)`	⬇️

kirkwaiblinger marked this pull request as draft

September 18, 2024 04:45

kirkwaiblinger commented

Sep 18, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-call.ts OutdatedShow resolvedHide resolved

weird edge cases

4076849

kirkwaiblinger marked this pull request as ready for review

September 18, 2024 06:14

comment

6de308b

kirkwaiblinger commented

Sep 18, 2024

View reviewed changes

packages/website/src/components/lib/parseConfig.ts

		@@ -55,7 +55,7 @@ export function parseTSConfig(code?: string): TSConfig {
		const moduleRegexp = /(module\.exports\s*=)/g;

		function constrainedScopeEval(obj: string): unknown {
		// eslint-disable-next-line @typescript-eslint/no-implied-eval
		// eslint-disable-next-line @typescript-eslint/no-implied-eval, @typescript-eslint/no-unsafe-call

Copy link

MemberAuthor

kirkwaiblingerSep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To be clear,

// this is the no-implied-eval violationconstyoloFunction=Function('inline function');// this is the no-unsafe-call violationyoloFunction();

They just happen to be on the same line here. So, this isn't a case of these rules stepping on each others' toes IMO.

naming

2239388

JoshuaKGoldberg requested changes

Sep 18, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome. Just some comments on testing/style, nothing major.

packages/eslint-plugin/docs/rules/no-unsafe-call.mdx

		}
		// etc
		}
		```

Copy link

Member

JoshuaKGoldbergSep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] Great example, really clear and concise.

packages/eslint-plugin/src/rules/no-unsafe-call.ts Outdated

		return;
		}
		} else {
		// eslint-disable-next-line no-lonely-if

Copy link

Member

JoshuaKGoldbergSep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link

MemberAuthor

kirkwaiblingerSep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oh. I'll revert that.

This is just my personal vendetta; Ireally,really dislike no-lonely-if. IMO if/elseif should only be used for conditions which can be safely reorded, which is incompatible with no-lonely-if