typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

feat(eslint-plugin): [no-base-to-string] handle String()#10005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 8 commits intotypescript-eslint:mainfromyeonjuan:fix/4314

Oct 27, 2024

Merged

feat(eslint-plugin): [no-base-to-string] handle String()#10005

JoshuaKGoldberg merged 8 commits intotypescript-eslint:mainfromyeonjuan:fix/4314

Oct 27, 2024

Conversation

Copy link

Contributor

yeonjuan commentedSep 17, 2024

PR Checklist

Addresses an existing open issue:fixes[no-base-to-string] doesn't catchString(…) #4314
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

feat(eslint-plugin): [no-base-to-string] handle String()

68b31c7

Copy link

Contributor

typescript-eslintbot commentedSep 17, 2024

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 17, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0220cf0`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/671a5a08eb378200080f949f
😎 Deploy Preview	https://deploy-preview-10005--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedSep 17, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0220cf0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedSep 17, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base(e765033) to head(0220cf0).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10005      +/-   ##==========================================+ Coverage   86.16%   86.19%   +0.02%==========================================  Files         430      430                Lines       15031    15063      +32       Branches     4361     4372      +11     ==========================================+ Hits        12951    12983      +32  Misses       1728     1728                Partials      352      352

Flag	Coverage Δ
unittest	`86.19% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`95.71% <100.00%> (+0.55%)`	⬆️

... and1 file with indirect coverage changes

yeonjuan added2 commits

September 18, 2024 23:43

fix

cd22963

Merge branch 'main' into fix/4314

8b40290

yeonjuan marked this pull request as ready for review

September 18, 2024 15:17

JoshuaKGoldberg requested changes

Sep 23, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems like a reasonable direction to me. But I think we'll need to handle customString functions?

packages/eslint-plugin/src/rules/no-base-to-string.ts Outdated

		if (
		node.callee.type === AST_NODE_TYPES.Identifier &&
		// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
		node.callee.name === 'String' &&

Copy link

Member

JoshuaKGoldbergSep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

// an annoying thing people sometimes dofunctionString(value){try{returnJSON.stringify(value);}catch{return`${value}`;}}// ...declareconstmyValue:object;String(myValue);

This should check with the scope analyzer to make sure the node is actually the built-inString, I think.

Copy link

ContributorAuthor

yeonjuanSep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@JoshuaKGoldberg Thanks!addf652

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Sep 23, 2024

kirkwaiblinger reviewed

Sep 23, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdxShow resolvedHide resolved

handle shadowed string

addf652

JoshuaKGoldberg mentioned this pull request

Sep 30, 2024

feat(eslint-plugin): [prefer-nullish-coalescing] add optionignoreBooleanCoercion#9924

Merged

3 tasks

kirkwaiblinger mentioned this pull request

Oct 21, 2024

feat(eslint-plugin): [no-unnecessary-type-conversion] add rule#10182

Merged

3 tasks

yeonjuan added2 commits

October 23, 2024 09:58

Merge branch 'main' into fix/4314

8f4f8dc

apply review

711639f

yeonjuan commented

Oct 23, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdxShow resolvedHide resolved

fix lint errors

80c39a0

kirkwaiblinger reviewed

Oct 23, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdx OutdatedShow resolvedHide resolved

kirkwaiblinger previously approved these changes

Oct 23, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Update packages/eslint-plugin/docs/rules/no-base-to-string.mdx

0220cf0

Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>

yeonjuan dismissedkirkwaiblinger’sstale review via0220cf0

October 24, 2024 14:30

yeonjuan requested a review fromJoshuaKGoldberg

October 24, 2024 14:30

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 24, 2024

kirkwaiblinger approved these changes

Oct 24, 2024

View reviewed changes

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Oct 24, 2024

Va992 mentioned this pull request

Oct 26, 2024

<spam>#10210

Closed

JoshuaKGoldberg merged commitac18749 intotypescript-eslint:main

Oct 27, 2024

64 of 65 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Oct 28, 2024

fix(deps): update typescript-eslint monorepo to v8.12.0

b74caac

##### [v8.12.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8120-2024-10-28)##### 🚀 Features-   **eslint-plugin:** \[no-base-to-string] handle String() ([#10005](typescript-eslint/typescript-eslint#10005))-   **eslint-plugin:** \[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option ([#9954](typescript-eslint/typescript-eslint#9954))-   **eslint-plugin:** \[consistent-indexed-object-style] report mapped types ([#10160](typescript-eslint/typescript-eslint#10160))-   **eslint-plugin:** \[prefer-nullish-coalescing] add support for assignment expressions ([#10152](typescript-eslint/typescript-eslint#10152))##### ❤️  Thank You-   Abraham Guo-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Oct 30, 2024

Update typescript-eslint monorepo to v8.12.2

65bc8bf

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.11.0 | 8.12.2 || npm        | @typescript-eslint/parser        | 8.11.0 | 8.12.2 |## [v8.12.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8122-2024-10-29)##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] invert `considerDefaultExhaustiveForUnions` ([#10223](typescript-eslint/typescript-eslint#10223))##### ❤️  Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.12.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8121-2024-10-28)This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.12.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8120-2024-10-28)##### 🚀 Features-   **eslint-plugin:** \[no-base-to-string] handle String() ([#10005](typescript-eslint/typescript-eslint#10005))-   **eslint-plugin:** \[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option ([#9954](typescript-eslint/typescript-eslint#9954))-   **eslint-plugin:** \[consistent-indexed-object-style] report mapped types ([#10160](typescript-eslint/typescript-eslint#10160))-   **eslint-plugin:** \[prefer-nullish-coalescing] add support for assignment expressions ([#10152](typescript-eslint/typescript-eslint#10152))##### ❤️  Thank You-   Abraham Guo-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Oct 30, 2024

Update typescript-eslint monorepo to v8.12.2

b6ece07

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.11.0 | 8.12.2 || npm        | @typescript-eslint/parser        | 8.11.0 | 8.12.2 |## [v8.12.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8122-2024-10-29)##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] invert `considerDefaultExhaustiveForUnions` ([#10223](typescript-eslint/typescript-eslint#10223))##### ❤️  Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.12.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8121-2024-10-28)This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.12.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8120-2024-10-28)##### 🚀 Features-   **eslint-plugin:** \[no-base-to-string] handle String() ([#10005](typescript-eslint/typescript-eslint#10005))-   **eslint-plugin:** \[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option ([#9954](typescript-eslint/typescript-eslint#9954))-   **eslint-plugin:** \[consistent-indexed-object-style] report mapped types ([#10160](typescript-eslint/typescript-eslint#10160))-   **eslint-plugin:** \[prefer-nullish-coalescing] add support for assignment expressions ([#10152](typescript-eslint/typescript-eslint#10152))##### ❤️  Thank You-   Abraham Guo-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Oct 31, 2024

Update typescript-eslint monorepo to v8.12.2

3bad492

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.11.0 | 8.12.2 || npm        | @typescript-eslint/parser        | 8.11.0 | 8.12.2 |## [v8.12.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8122-2024-10-29)##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] invert `considerDefaultExhaustiveForUnions` ([#10223](typescript-eslint/typescript-eslint#10223))##### ❤️  Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.12.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8121-2024-10-28)This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.12.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8120-2024-10-28)##### 🚀 Features-   **eslint-plugin:** \[no-base-to-string] handle String() ([#10005](typescript-eslint/typescript-eslint#10005))-   **eslint-plugin:** \[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option ([#9954](typescript-eslint/typescript-eslint#9954))-   **eslint-plugin:** \[consistent-indexed-object-style] report mapped types ([#10160](typescript-eslint/typescript-eslint#10160))-   **eslint-plugin:** \[prefer-nullish-coalescing] add support for assignment expressions ([#10152](typescript-eslint/typescript-eslint#10152))##### ❤️  Thank You-   Abraham Guo-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.