Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
refactor(typescript-estree): correct warnings reported by sonarlint#100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -11,11 +11,11 @@ import { convertTokens } from './node-utils'; | |||
| import ts from 'typescript'; | |||
| import { Extra } from './temp-types-based-on-js-source'; | |||
| export default ( | |||
| export defaultfunction astConverter( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
its easier to profile named functions
armano2 commentedJan 21, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov doesn't like my change (even if it's just refactoring) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@armano2 loggerFn is needed - prettier and some others use it |
ohh, i used bad wording, there is no tests if it's actually working |
Codecov Report
@@ Coverage Diff @@## master #100 +/- ##==========================================+ Coverage 94.83% 94.99% +0.15%========================================== Files 48 48 Lines 2480 2479 -1 Branches 381 381 ==========================================+ Hits 2352 2355 +3+ Misses 77 75 -2+ Partials 51 49 -2
|
This PR fixes issues found in code by static code analysis by SonarLint.