Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I havesearched for related issues and found none that match my proposal.
- I have searched thecurrent rule list and found no rules that match my proposal.
- I haveread the FAQ and my problem is not listed.
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Link to the rule's documentation
https://typescript-eslint.io/rules/no-unnecessary-type-parameters/
Description
Add suggestions with the intended fix.
Fail
functiontoUnknown<T>(x:T):unknown{returnx;}functionwithExtends<Textendsnumber|string>(x:T):unknown{returnMath.random();}
Pass
// replace unconstrained input generic with unknownfunctiontoUnknown(x:unknown):unknown{returnx;}// replace constrained input generic with its constraint typefunctionwithExtends(x:number|string):unknown{returnMath.random();}
Additional Info
There are probably more cases where we could make suggestions, too. These are just the first things that came to mind. I think that adding these suggestions would have high value to help the user understood why the rule is reporting, since this rule is quite subtle
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin