Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Labels
enhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginteam assignedA member of the typescript-eslint team should work on this.
Milestone
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I havesearched for related issues and found none that match my proposal.
- I have searched thecurrent rule list and found no rules that match my proposal.
- I haveread the FAQ and my problem is not listed.
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Link to the rule's documentation
https://v8--typescript-eslint.netlify.app/rules/no-floating-promises
Description
Following#8433 ->#9263: we'd resolved to add a newcheckThenables
option to theno-floating-promises
rule. It's enabled by default in v7 to avoid a breaking change. But for v8 we'd like to disable it by default.
Fail
/*@typescript-eslint/no-floating-promises: ["error", { "checkThenables": true }] */interfaceMyThenableextendsPromiseLike<string>{}declarefunctioncreateMyThenable():Promise<string>;createMyThenable();
Pass
interfaceMyThenableextendsPromiseLike<string>{}declarefunctioncreateMyThenable():MyThenable;createMyThenable();
Additional Info
💖
Metadata
Metadata
Assignees
Labels
enhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginteam assignedA member of the typescript-eslint team should work on this.