Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enhancement: replaceglobby withfast-glob #9453

Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancementNew feature or requestlocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
@SukkaW

Description

@SukkaW

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

typescript-estree

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

Previously, typescript-eslint switched fromglob toglobby fortsconfig.json file searching:#2418

Under the hood,globby is powered byfast-glob with extra features, but none of them are utilized by thetypescript-eslint.

Since thetypescript-eslint doesn't utilize those extra features, I propose replacingglobby withfast-glob to reduce the installation size.

Additional Info

The installation size difference

The installation size ofglobby is 605 KiB and 23 transitive dependencies are introduced, whilethe installation size offast-glob is 503 KiB and 18 transitive dependencies are introduced.

Proof of Concept

I've tested the proposal in my fork:SukkaW@0cec339 and all existing test cases are passed on my machine.

globby's extra features

Here is globby's feature description:

  • Promise API
    • fast-glob also has promise-based API, andtypescript-eslint only uses the sync API
  • Multiple patterns
    • globby's multiple patterns support is powered byfast-glob directly
  • Negated patterns:['foo*', '!foobar']
    • globby's negated patterns support is also powered byfast-glob directly
  • Expands directories:foo → foo/**/*
    • typescript-eslint doesn't rely on this feature since the exact matches oftsconfig.json (-like) files are required
  • Supports.gitignore and similar ignore config files
    • typescript-eslint doesn't rely on this feature sinceglobby disabled this feature by default andtypescript-eslint doesn't enable it.
  • Supports URL ascwd
    • Currentlytypescript-eslint passed the string path tocwd, and we can use Node.js built-inurl.fileURLToPath in case we encounter URLs in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancementNew feature or requestlocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp