Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Repo: don't install dependencies for the entire repo in "Semantic Breaking Change PR" workflow #9447

Closed
Labels
locked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsteam assignedA member of the typescript-eslint team should work on this.
@auvred

Description

@auvred

Suggestion

Is there any reason why we want to install deps before running thebreaking-pr-check action? It does not import any repo-specific packages:

constcore=require('@actions/core');
constgithub=require('@actions/github');
functionraiseError(message){

Suggestion: let's remove this line?

-uses:./.github/actions/prepare-install

I noticed this, because it takes ~2 mins to runprepare-install and ~0 seconds to validate PR title (https://github.com/typescript-eslint/typescript-eslint/actions/runs/9712997933/job/26808863383?pr=9444)

prepare-install action took 2 minutes to run and breaking-pr-check finished instantly

cc@yeonjuan

Metadata

Metadata

Assignees

No one assigned

    Labels

    locked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsteam assignedA member of the typescript-eslint team should work on this.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      [8]ページ先頭
      ©2009-2025 Movatter.jp