Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I havesearched for related issues and found none that match my proposal.
- I have searched thecurrent rule list and found no rules that match my proposal.
- I haveread the FAQ and my problem is not listed.
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Link to the rule's documentation
https://typescript-eslint.io/rules/use-unknown-in-catch-callback-variable/
Description
I propose an option to only check on inline functions, i.e..catch((foo) => bar)
and not.catch(baz)
. Ifbaz
acceptsany
, it's either from an external library or will be flagged by--noImplicitAny
/no-explicit-any
.
Use case: I have a few instances of.catch(console.error)
in my codebase to log errors without throwing.console.error
is typed as(...data: any[]): void
, and as such this rule triggers an error.
Fail
Promise.resolve().catch((error)=>error)// Preserve old behavior
Pass
Promise.resolve().catch((error:unknown)=>error)// Preserve old behaviorPromise.resolve().catch(console.log)// Would previously errorPromise.resolve().catch(foo)// Would previously errorfunctionfoo(bar:any){}
Additional Info
No response
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin