Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedenhancementNew feature or requestgood first issueGood for newcomerslocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Milestone
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I havesearched for related issues and found none that match my proposal.
- I have searched thecurrent rule list and found no rules that match my proposal.
- I haveread the FAQ and my problem is not listed.
Relevant Package
ast-spec
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Description
Following#8089: we noticed that theIsNullableTypeOptions interface is never actually used in the places it's taken in, such as theisNullableType function later in the file:
typescript-eslint/packages/type-utils/src/predicates.ts
Lines 9 to 18 in85ae4a8
| exportinterfaceIsNullableTypeOptions{ | |
| /** | |
| *@deprecated - this flag no longer does anything and will be removed in the next major | |
| */ | |
| isReceiver?:boolean; | |
| /** | |
| *@deprecated - this flag no longer does anything and will be removed in the next major | |
| */ | |
| allowUndefined?:boolean; | |
| } |
We wanted to delete the unused interface, but doing so would be a breaking change. Now that we're working on v8 it's time - let's delete the code! 🔪
Additional Info
Note that the PR for this should be targeted against thev8 branch.
💖
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedenhancementNew feature or requestgood first issueGood for newcomerslocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.