Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I havesearched for related issues and found none that match my proposal.
- I have searched thecurrent rule list and found no rules that match my proposal.
- I haveread the FAQ and my problem is not listed.
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Link to the rule's documentation
https://typescript-eslint.io/rules/restrict-template-expressions/
Description
Related:#6279
I have added theallowArray
option torestrict-template-expressions
in#8389.
Now, I'd like to discuss other things that may be useful to put in a string. The most common case for me is stringifyingURLSearchParams
,Date
andBuffer
s, but there could be potential for others as well.
Some questions for discussion:
- Do we add a new option
ignoredTypeNames
? (I have created a draft PRfeat: addallow
option forrestrict-template-expressions
#8556 implementing this) - What will be the default value for this option?
- What does this mean for the
no-base-to-string
rule, which is becoming increasingly similar to this rule?
Fail
declareconstmaybeParams:URLSearchParams|undefined;fetch(`https://myapi.com?${maybeParams}`);
Pass
declareconstdefinitelyParams:URLSearchParams;fetch(`https://myapi.com?${definitelyParams}`);
Additional Info
No response
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin