Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Description
Overview
Copying@fisker's#6760 (comment):
I want give an update here, we (Prettier) can remove all the invalid node checks after upgrade to latest v6, so we can now use
parse
dirctly instead ofparseWithNodeMaps
. I think this method was added because Prettier need it at that moment, feel free to remove it if you think it's unnecessary to keep.
We always like deleting unused code! Just checking on Sourcegraph,https://sourcegraph.com/search?q=context:global+parseWithNodeMaps+-repo:.*typescript-eslint.*+-file:.*node_modules.*&patternType=standard&sm=1&groupBy=repo shows exactly one other runtime use:brodybits/prettierx ›src/language-js/parser-typescript.js: a fork of prettier not updated since 2021. cc @brodybits
I think it's safe to removeparseWithNodeMaps
. Filing this issue under triage to check with @typescript-eslint/triage-team.