Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove parseWithNodeMaps #7119

Closed
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedenhancementNew feature or requestpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estree
Milestone
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Overview

Copying@fisker's#6760 (comment):

I want give an update here, we (Prettier) can remove all the invalid node checks after upgrade to latest v6, so we can now useparse dirctly instead ofparseWithNodeMaps. I think this method was added because Prettier need it at that moment, feel free to remove it if you think it's unnecessary to keep.

We always like deleting unused code! Just checking on Sourcegraph,https://sourcegraph.com/search?q=context:global+parseWithNodeMaps+-repo:.*typescript-eslint.*+-file:.*node_modules.*&patternType=standard&sm=1&groupBy=repo shows exactly one other runtime use:brodybits/prettierxsrc/language-js/parser-typescript.js: a fork of prettier not updated since 2021. cc @brodybits

I think it's safe to removeparseWithNodeMaps. Filing this issue under triage to check with @typescript-eslint/triage-team.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedenhancementNew feature or requestpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estree

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp