Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Repo: ESLint warnings in useSandboxServices (react-hooks/exhaustive-deps) #6917

Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docs
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Suggestion

/home/runner/work/typescript-eslint/typescript-eslint/packages/website/src/components/editor/useSandboxServices.tsWarning:   128:6  warning  React Hook useEffect has missing dependencies: 'colorMode', 'onLoaded', and 'props'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

Example:#6907 ->https://github.com/typescript-eslint/typescript-eslint/actions/runs/4703925812/jobs/8343076171?pr=6907

This is showing up in PRs. Can we fix for the rule's complaint without causing bugs in the playground?

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      [8]ページ先頭
      ©2009-2025 Movatter.jp