Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Description
Suggestion
Coming over from#6350: we had an issue with our React code caused by us using invalid HTML. Specifically, React was logging this:
Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.We should end-to-end test to make sure this doesn't happen on the homepage again. Right now we just test that the homepage has no accessibility issues detectable byaXe:
typescript-eslint/packages/website/tests/index.spec.ts
Lines 4 to 7 in9ffdb05
| test('Index',async({ page})=>{ | |
| awaitpage.goto('/'); | |
| awaitnewAxeBuilder({ page}).analyze(); | |
| }); |
Playwright is able to listen to console messages. I propose we make a second end-to-end test that checks to make sure noconsole.error calls happened.
It wouldn't surprise me if a library already exists for Playwright somewhere that does this...