Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Assignees
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I havesearched for related issues and found none that match my proposal.
- I have searched thecurrent rule list and found no rules that match my proposal.
- I haveread the FAQ and my problem is not listed.
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Link to the rule's documentation
https://typescript-eslint.io/rules/consistent-generic-constructors/
Description
I think the rule should check function and constructor arguments with default parameter values as well
Related rule:no-inferrable-types
Fail
/* eslint "@typescript-eslint/consistent-generic-constructors": ["error", "constructor"] */classFoo1{bar(baz:Set<string>=newSet()){}}classFoo2{constructor(bar:Set<string>=newSet()){}}/* eslint "@typescript-eslint/consistent-generic-constructors": ["error", "type-annotation"] */classFoo1{bar(baz=newSet<string>()){}}classFoo2{constructor(bar=newSet<string>()){}}
Pass
/* eslint "@typescript-eslint/consistent-generic-constructors": ["error", "constructor"] */classFoo1{bar(baz=newSet<string>()){}}classFoo2{constructor(bar=newSet<string>()){}}/* eslint "@typescript-eslint/consistent-generic-constructors": ["error", "type-annotation"] */classFoo1{bar(baz:Set<string>=newSet()){}}classFoo2{constructor(bar:Set<string>=newSet()){}}
Additional Info
No response