Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I havesearched for related issues and found none that matched my issue.
- I haveread the FAQ and my problem is not listed.
Playground Link
Repro Code
declareletj:unknown;letm={ ...(jas{})};
ESLint Config
module.exports={parser:"@typescript-eslint/parser",rules:{"@typescript-eslint/ban-types":"error",},};
tsconfig
No response
Expected Result
From@RyanCavanaugh in#5018:
Now that
objecthas been shipping in TS for several years, this seems like a safe suggestion in lieu ofRecord's messy side effects
From@bradzacher in#5018 (comment):
The issue with
objectas a suggested replacement has always been that it's really hard use (microsoft/TypeScript#21732).
#21732 -> github.com/microsoft/TypeScript/pull/50666 has been shipped, so the major flaws mentioned should be gone now.
Proposal: let's suggestobject:
- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.+ If you want a type meaning "any object", you probably want `object` instead.
I'm unsure what to do about{}. On the one hand:
Having typescript-eslint, out of the box, ban you from writing a type that TypeScript itself is inferring under totally normal operation, is awkward.
On the other hand, people do mistake it for "any object". 🤔
Actual Result
Right now we still recommend:
Don't use `{}` as a type. `{}` actually means "any non-nullish value".- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.- If you want a type meaning "any value", you probably want `unknown` instead.- If you want a type meaning "empty object", you probably want `Record<string, never>` instead.Additional Info
Originally suggested by@RyanCavanaugh in#5018.
Versions
| package | version |
|---|---|
@typescript-eslint/eslint-plugin | 5.42.1 |
@typescript-eslint/parser | 5.42.1 |
TypeScript | 4.8.4 |
ESLint | 8.15.0 |
node | web |