Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Description
Suggestion
#5251 (comment):yarn generate:configs doesn't actually... work right now locally.
$ ../../node_modules/.bin/ts-node --files --transpile-only tools/generate-configs.ts/home/josh/repos/typescript-eslint/packages/eslint-plugin/tools/generate-configs.ts:6import rules from '../src/rules'; ^Error [ERR_REQUIRE_ESM]: require() of ES Module /home/josh/repos/typescript-eslint/packages/eslint-plugin/node_modules/chalk/source/index.js from /home/josh/repos/typescript-eslint/packages/eslint-plugin/tools/generate-configs.ts not supported.Instead change the require of index.js in /home/josh/repos/typescript-eslint/packages/eslint-plugin/tools/generate-configs.ts to a dynamic import() which is available in all CommonJS modules. at Object.<anonymous> (/home/josh/repos/typescript-eslint/packages/eslint-plugin/tools/generate-configs.ts:6:33) at Module.m._compile (/home/josh/repos/typescript-eslint/node_modules/ts-node/dist/index.js:791:29) at Object.require.extensions.<computed> [as .ts] (/home/josh/repos/typescript-eslint/node_modules/ts-node/dist/index.js:793:16) at phase4 (/home/josh/repos/typescript-eslint/node_modules/ts-node/dist/bin.js:407:16) at bootstrap (/home/josh/repos/typescript-eslint/node_modules/ts-node/dist/bin.js:49:12) at main (/home/josh/repos/typescript-eslint/node_modules/ts-node/dist/bin.js:32:12) at Object.<anonymous> (/home/josh/repos/typescript-eslint/node_modules/ts-node/dist/bin.js:519:5) { code: 'ERR_REQUIRE_ESM'}#4952 bumpedchalk to v5, which is an ESM-only version. You can read about the context about ESM-only packages here:https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c.
Unfortunately we're not yet on pure ESM for our source scripts, and so cannot use this new version ofchalk. We'll have to downgradechalk to v4.
We don't have any CI task verifying thatyarn generate:configs does not crash - so we have no way of knowing that any change breaks that particular script, unless we think to explicitly test it.
Proposal: let's add a new job toci.yml that verifiesyarn generate:configs does not exit with an error code?