Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor: Remove createIsolatedProgram call from getProgramAndAST #5856

Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedlocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.refactorPRs that refactor code only
Milestone
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Overview

createDefaultProgram(code,extra))||
createIsolatedProgram(code,extra)

That last|| createIsolatedProgram(code, extra)should never be hit. We believe it was a just-in-case fallback added long ago that is no longer (and maybe never was) needed.

Removing that case may make#5855 easier.

Marking as accepting PRs with the caveat that everything still has to work as expected. Which may or may not be doable. Good luck! 😄

This issue is from a pairing I had with@bradzacher going over the parser internals.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedlocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.refactorPRs that refactor code only

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      [8]ページ先頭
      ©2009-2025 Movatter.jp