Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rule proposal: Loop style - .find, for-i, for-of, forEach #5710

Open
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: new plugin ruleNew rule request for eslint-pluginpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • My proposal specifically checks TypeScript syntax, or it proposes a check that requires type information to be accurate.
  • My proposal is not a "formatting rule"; meaning it does not just enforce how code is formatted (whitespace, brace placement, etc).
  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

Following#5027 (comment): it can sometimes be more terse to use an Array method like.find over afor loop.

Fail Cases

functiontraditionalForLoop(array:string[],condition:(item:string)=>boolean){for(leti=0;i<array.length;i+=1){if(condition(array[i])){returnarray[i];}}}functionforOfLoop(array:string[],condition:(item:string)=>boolean){for(constitemofarray){if(condition(item)){returnitem;}}}

Pass Cases

functionfixed(array:string[],condition:(item:string)=>boolean){returnarray.find(item=>condition(item));}

Additional Info

Filing it in typescript-eslint rather than ESLint core because the rule'd want to use type information to know the iterated-over collection is an array.

Storing a variable likelet found: string | undefined should also match the rule.

As@bradzacher said in#5027 (comment), this is a relatively complex code construct to detect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancement: new plugin ruleNew rule request for eslint-pluginpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp