Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Description
PR#367 seems to have introduced a number of unexpected false linter errors when used in combination witheslint-plugin-vue
. I think the problem boils down to the assumption from the PR that this function will only get called twice if in watch or fix mode not being valid.
With single-file-components in .vue files, this function winds up getting called for each section of the file that may contain scripts. Naturally this includes the<script></script>
block, but also includes things like interpolations and v-bind's, etc. Each time getting called with the samefilePath
.
What code were you trying to parse?
See the following reproducer:
https://github.com/thebanjomatic/lint-repro
What did you expect to happen?
Running lint should not produce false errors
What actually happened?
Parsing appears to be broken and a multitude of different lint errors are produced.
Versions
package | version |
---|---|
@typescript-eslint/typescript-estree | >= 1.5.0 |
TypeScript | 3.3.4000 |
node | 8.15.0 |
npm | 6.4.1 |