Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[restrict-plus-operands] false positive on type parameters #230

Closed
Labels
bugSomething isn't workingenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulepackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
@mysticatea

Description

@mysticatea

Repro

{"plugins": ["@typescript-eslint"],"rules": {"@typescript-eslint/restrict-plus-operands":"error"  }}
functionfoo<Textendsstring>(a:T){returna+""// error}functionfoo<Textends"a"|"b">(a:T){returna+""// error}

Expected Result

No errors.

Actual Result

There are two errors ata + "".

  restrict-plus-operands    valid      √ var x = 5; (1469ms)      √ var y = "10"; (736ms)      √ var z = 8.2; (644ms)      √ var w = "6.5"; (503ms)      √ var foo = 5 + 10; (629ms)      √ var foo = "5.5" + "10"; (490ms)      √ var foo = parseInt("5.5", 10) + 10; (530ms)      √ var foo = parseFloat("5.5", 10) + 10; (545ms)      √ function test () : number { return 2; }var foo = test("5.5", 10) + 10;             (487ms)      √ var x = 5;var z = 8.2;var foo = x + z;             (646ms)      √ var w = "6.5";var y = "10";var foo = y + w;             (631ms)      √ var foo = 1 + 1; (539ms)      √ var foo = '1' + '1'; (509ms)      √ var pair: { first: number, second: string } = { first: 5, second: "10" };var foo = pair.first + 10;             (558ms)      √ var pair: { first: number, second: string } = { first: 5, second: "10" };var foo = pair.first + (10 as number);             (540ms)      √ var pair: { first: number, second: string } = { first: 5, second: "10" };var foo = "5.5" + pair.second;             (513ms)      √ var pair: { first: number, second: string } = { first: 5, second: "10" };var foo = ("5.5" as string) + pair.second;             (637ms)      √ const foo = 'hello' + (someBoolean ? 'a' : 'b') + (() => someBoolean ? 'c' : 'd')() + 'e'; (606ms)      √ const balls = true; (681ms)      √ balls === true; (579ms)      1)       function foo<T extends "a" | "b">(a: T) {          return a + ""      }          2)       function foo<T extends string>(a: T) {          return a + ""      }          √       function foo(a: "a" | "b") {          return a + ""      }     (566ms)    invalid      √ var foo = '1' + 1; (623ms)      √ var foo = [] + {}; (554ms)      √ var foo = 5 + "10"; (479ms)      √ var foo = [] + 5; (495ms)      √ var foo = [] + {}; (509ms)      √ var foo = [] + []; (447ms)      √ var foo = 5 + []; (592ms)      √ var foo = "5" + {}; (544ms)      √ var foo = 5.5 + "5"; (534ms)      √ var foo = "5.5" + 5; (537ms)      √ var x = 5;var y = "10";var foo = x + y;             (642ms)      √ var x = 5;var y = "10";var foo = y + x;             (496ms)      √ var x = 5;var foo = x + {};             (509ms)      √ var y = "10";var foo = [] + y;             (515ms)      √ var pair: { first: number, second: string } = { first: 5, second: "10" };var foo = pair.first + "10";             (483ms)      √ var pair: { first: number, second: string } = { first: 5, second: "10" };var foo = 5 + pair.second;             (515ms)      √ var foo = parseInt("5.5", 10) + "10"; (483ms)      √ var pair = { first: 5, second: "10" };var foo = pair + pair;             (492ms)  39 passing (24s)  2 failing  1) restrict-plus-operands       valid      function foo<T extends "a" | "b">(a: T) {          return a + ""      }    :      AssertionError [ERR_ASSERTION]: Should have no errors but had 1: [ { ruleId: 'restrict-plus-operands',    severity: 1,    message:     "Operands of '+' operation must either be both strings or both numbers. Consider using a template literal.",    line: 3,    column: 18,    nodeType: 'BinaryExpression',    messageId: 'notStrings',    endLine: 3,    endColumn: 24 } ]      + expected - actual      -1      +0      at testValidTemplate (node_modules\eslint\lib\testers\rule-tester.js:415:20)      at Context.RuleTester.it (node_modules\eslint\lib\testers\rule-tester.js:584:25)  2) restrict-plus-operands       valid      function foo<T extends string>(a: T) {          return a + ""      }    :      AssertionError [ERR_ASSERTION]: Should have no errors but had 1: [ { ruleId: 'restrict-plus-operands',    severity: 1,    message:     "Operands of '+' operation must either be both strings or both numbers. Consider using a template literal.",    line: 3,    column: 18,    nodeType: 'BinaryExpression',    messageId: 'notStrings',    endLine: 3,    endColumn: 24 } ]      + expected - actual      -1      +0      at testValidTemplate (node_modules\eslint\lib\testers\rule-tester.js:415:20)      at Context.RuleTester.it (node_modules\eslint\lib\testers\rule-tester.js:584:25)

Additional Info

Nothing in particular.

Versions

packageversion
@typescript-eslint/eslint-pluginmaster
@typescript-eslint/parsermaster
TypeScript3.3.1
ESLint5.12.1
node11.9.0
npm6.7.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulepackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp