Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Description
#1698 introduced a regression for TS<3.8.x (#1746).
This wasn't caught by the type checker, nor was it caught by the tests because both were using TS3.8.
It was a simple mistake, but one that shouldn't have happened.
We should add an integration test in order to make sure that this doesn't happen again.
We cannot run builds against older versions of TS, because our code relies upon property types etc added by the latest versions, but we can easily run tests against the old versions.
I don't think we need to testevery version we support, but at least testing against the previous one or two minors and the minimum supported version should be good enough.
Regressions that would have been caught:
- Regression in 2.24.0: TypeError: Cannot read property 'name' of undefined #1746 -feat(typescript-estree): support 3.8
export * as ns
#1698 used an enum value added in TS3.8. - Receiving Parsing error: not implemented on v2.24.0 #1759 -fix: unecessary program updates by removing timeout methods #1693 relied upon functionality added in TS3.3.
- [no-unsafe-return] TypeError: checker.getTypeArguments is not a function #1807 - feat(eslint-plugin): add rule no-unsafe-return #1644 used an API added in TS3.7.
- chore: upgrade local ts version to 4.0.0-beta #2305 produced an incorrect AST for <TS4.0.
- Bug: [no-unused-vars] 'Component' is defined but never used #5571 -feat: support TypeScript 4.8 #5551 broke exported decorators for <TS4.8.