Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): forbid computedEnumMember#11232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
fisker wants to merge9 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromfisker:non-computed-enum-member

Conversation

fisker
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 21, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf60ffa6
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/682e27c4373c8f0008fd9864
😎 Deploy Previewhttps://deploy-preview-11232--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 21, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf60ffa6.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5mView ↗
nx run-many -t typecheck✅ Succeeded2m 10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded18sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded7sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run-many -t lint✅ Succeeded8sView ↗
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-05-21 19:35:50 UTC

@fiskerfiskerforce-pushed thenon-computed-enum-member branch from45c92cb to82e8533CompareMay 21, 2025 17:18
@fiskerfisker marked this pull request as draftMay 21, 2025 17:31
Comment on lines +636 to +637
// Unknown reason, can't get the correct type
const id = node.id as TSESTree.Identifier | TSESTree.StringLiteral;
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the build script is using the published package instead of local one. I tried to useworkspace:^, but still can't build.

@codecovCodecov
Copy link

codecovbot commentedMay 21, 2025

Codecov Report

Attention: Patch coverage is66.66667% with13 lines in your changes missing coverage. Please review.

Project coverage is 90.88%. Comparing base(4ad8a07) to head(f60ffa6).

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts62.85%13 Missing⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11232      +/-   ##==========================================- Coverage   90.91%   90.88%   -0.03%==========================================  Files         501      501                Lines       50869    50887      +18       Branches     8382     8380       -2     ==========================================+ Hits        46248    46250       +2- Misses       4606     4622      +16  Partials       15       15
FlagCoverage Δ
unittest90.88% <66.66%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts97.79% <100.00%> (-0.02%)⬇️
...ackages/scope-manager/src/referencer/Referencer.ts97.93% <100.00%> (-0.01%)⬇️
packages/typescript-estree/src/convert.ts30.81% <62.85%> (+0.15%)⬆️

... and2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fiskerfisker marked this pull request as ready for reviewMay 21, 2025 19:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@fisker
[8]ページ先頭
©2009-2025 Movatter.jp