Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I havesearched for related issues and found none that match my proposal.
- I have searched thecurrent rule list and found no rules that match my proposal.
- I haveread the FAQ and my problem is not listed.
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Link to the rule's documentation
https://typescript-eslint.io/rules/prefer-nullish-coalescing/
Description
I propose that the rule should flagif
statements that are equivalent to a nullish coalescing assignment (??=
).
Fail
declareletfoo:{a:string}|null;declarefunctionmakeFoo():{a:string};functionlazyInitializeByTruthiness(){if(!foo){foo=makeFoo();}}functionlazyInitializeByNullCheck(){if(foo==null){foo=makeFoo();}}export{}
Pass
declareletfoo:{a:string}|null;declarefunctionmakeFoo():{a:string};functionlazyInitializeByNullishCoalescingAssignment(){foo??=makeFoo();}export{}
Additional Info
relates to#6309
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin