Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed as duplicate of#2770
Closed as duplicate of#2770
Labels
enhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugintriageWaiting for team members to take a look
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I havesearched for related issues and found none that match my proposal.
- I have searched thecurrent rule list and found no rules that match my proposal.
- I haveread the FAQ and my problem is not listed.
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Link to the rule's documentation
https://typescript-eslint.io/rules/no-unnecessary-condition/
Description
I was using the rule no-unnecessary-condition, until I started my first react project where you often useconditional rendering in your tsx code. For example like:
{radioButtonHasMemberIsYes&&<><inputname='firstname'type='text'/><inputname='lastname'type='text'/></>}
Unfortunately no-unnecessary-condition breaks at this point because the second part of the condition is always truthy. It would be nice to be able to configure this rule so that this type of condition would be allowed by deactivating each of the following expressions (if needed):
- Arguments to the &&, || and ?: (ternary) operators
- Conditions for if, for, while, and do-while statements
- cases in switch statements
- Base values of optional chain expression
Fail
Pass
constradioButtonHasMemberIsYes=true{radioButtonHasMemberIsYes&&<><inputname='firstname'type='text'/><inputname='lastname'type='text'/></>}
Additional Info
No response
Metadata
Metadata
Assignees
Labels
enhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugintriageWaiting for team members to take a look