Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Closed
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I havesearched for related issues and found none that matched my issue.
- I haveread the FAQ and my problem is not listed.
Playground Link
Repro Code
`${/* intentional comment */''}...`;
ESLint Config
module.exports={"rules":{"@typescript-eslint/no-unnecessary-template-expression":"error"}}
tsconfig
{"compilerOptions": {"strictNullChecks":true }}
Expected Result
No error, as there's no other way to include the comment there.
Actual Result
Template literal expression is unnecessary and can be simplified. 2:1 - 2:32
Additional Info
Discovered in TypeHero, thanks for letting me do user research on you@bautistaaa 😄:https://github.com/typehero/typehero/blob/0b7a25895c6ffc3707fd1a6348b31f2d38b81b95/tooling/scripts/dl-monaco.ts#L85-L86
${/* needs to import from monaco-editor to access the Environment type */''}declareletMonacoEnvironment:import("monaco-editor").Environment|undefined;