Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Changes to configurations for 8.0.0#8914
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
BetaWas this translation helpful?Give feedback.
All reactions
👍 8
Replies: 11 comments 14 replies
-
Fun fact, I somewhat auto-generated this table. 😎https://github.com/JoshuaKGoldberg/repros/tree/ts-eslint-v8-config-changes-generator |
BetaWas this translation helpful?Give feedback.
All reactions
❤️ 2🚀 3
-
If no-useless-template-literal is destined to be renamed, should we sneak that in before it gets added to recommended to minimize impact of the renaming (on things like disable comments etc)? |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1
-
Agreed, added to the v8 milestone. Good call! |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
Interesting note:prefer-find andprefer-includes at first seem like rules that would be in |
BetaWas this translation helpful?Give feedback.
All reactions
👎 1
-
The way I see it, both those rules satisfy the conditions when flagging that "there is a unique and uncontroversially better way to write this, though there is not a significant correctness concern with the existing code". So there's no reason ever to not want them, but they're not terribly important to use either. As a user my intuition would that that should be part of strict, whereas stylistic would have to do more with opinionated things that don't have a uniquely better way to write them; one is just picked largely for the sake of consistency (consistent-type-assertions springs to mind as a good example of this). Idk if that's really the intention of those configs or not, though. |
BetaWas this translation helpful?Give feedback.
All reactions
-
I think it would be good to also consider that strict is recommended only for proficient typescript developers. And I think these rules are easy to use and easy to adopt. So they could go for stylistics in that sense. I think
|
BetaWas this translation helpful?Give feedback.
All reactions
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
I'm leaning towards |
BetaWas this translation helpful?Give feedback.
All reactions
-
Here are some rules I find handy Add
|
BetaWas this translation helpful?Give feedback.
All reactions
-
🤔 |
BetaWas this translation helpful?Give feedback.
All reactions
👍 3
-
It's a useful rule if you have to use |
BetaWas this translation helpful?Give feedback.
All reactions
👍 2
-
Just heads up, ➕ and ➖ emojis are not visible on dark mode. |
BetaWas this translation helpful?Give feedback.
All reactions
-
Oh, blurgh. Good callout. Now we have to figure out - what's a good replacement pair of emojis... 🤔 |
BetaWas this translation helpful?Give feedback.
All reactions
-
remove: 🗑️ (or ❌ but that is too red IMO.) (I honestly do not know, I think it could be just |
BetaWas this translation helpful?Give feedback.
All reactions
-
Mmhh it'd be nice to have two emojis with meanings related to each other... surprisingly hard to find. I'm surprised there aren't + and - versions in squares the way there are 🔼 / 🔽 . |
BetaWas this translation helpful?Give feedback.
All reactions
-
👍 / 👎 :D There is ✅ and ❎ but I think those are hard for some people as they use same color and the different symbol is just so small. I think the table could use ✨ for meaning "new". Both meaning as a new rule and as a new item in shared config. Because I had difficulties remembering what every emoji means :D But I'll leave this to you (or others) to find best option. (Found this kind of tool where you could check in both modes easilyhttps://github-emoji-picker.rickstaa.dev/ but emojis are pretty limited in this way) |
BetaWas this translation helpful?Give feedback.
All reactions
-
|
BetaWas this translation helpful?Give feedback.
All reactions
👍 2
-
I like it! It straddles the line between "recommended" and "stylistic"... but given the strong TypeScript push, that's enough for me to be happy switching it over. |
BetaWas this translation helpful?Give feedback.
All reactions
-
Update (May 11th): with#8977's |
BetaWas this translation helpful?Give feedback.
All reactions
-
Note that once#9102 is merged, we'll have some more changes to the table. |
BetaWas this translation helpful?Give feedback.
All reactions
-
I'm excited to see all this work on v8! Is there a rough timeline for when this version will drop? I think I'm right in saying ESLint v9 has been out nearly a couple of months now but the current version of typescript-eslint doesn't support it, preventing new users/projects from using the latest major version. |
BetaWas this translation helpful?Give feedback.
All reactions
❤️ 1
-
No strict timeline. When we get to things, really. As volunteer maintainers we work on things when we have the bandwidth -- and unfortunately we haven't had the bandwidth. ESLint sadly did not coordinate with us and released before we were ready and at a time where we have been time poor. |
BetaWas this translation helpful?Give feedback.
All reactions
👍 3
-
Coming over from#9079 (comment): we're going to try out moving@typescript-eslint/no-unused-expressions to |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1
-
Calling out that return-await is on track to be added to the strict config, a la#8667/#9604 |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1🚀 1
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
I'm coming from blog posthttps://typescript-eslint.io/blog/announcing-typescript-eslint-v8 to see what where the actual changes to some rules. :) Some updates that could be made to table or just noting these here for next user that is curious why they are listed removed in config diffs. Though if you read the blog lost further, you also get the same explanation :D
|
BetaWas this translation helpful?Give feedback.
All reactions
-
Aha thank you, great callout! Updating now. |
BetaWas this translation helpful?Give feedback.