Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Configs: Have recommended/strict configs include lesser configs, and simplify type checked names#6019
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
DescriptionEdited December 8th, 2022: updated to include@aaronadamsCA's#6019 (comment) and@robertknight's#6014 (comment) to this proposal. ContextRight now, no config in the following list of configs provided with typescript-eslint includes any other config in that list:
That means if you want, say, the strictest, you must enable all three (https://typescript-eslint.io/docs/linting/configs): {"extends":["plugin:@typescript-eslint/recommended","plugin:@typescript-eslint/recommended-requiring-type-checking","plugin:@typescript-eslint/strict"]} That's very inconvenient -and sometimes even confusing- for end users. Breaking Change: Including Lesser ConfigsProposal: how about we have each config in that list also include any previous config in the list? That way if you want, say, the {"extends":["plugin:@typescript-eslint/strict"]} Associated Enhancement: More Delineated ConfigsWe've received occasional user feedback (e.g.#6014 (comment)) that ourrecommended rulesets also include somestylistic rules. The ESLint community has generally moved away from the old 2010s-era eslint-config-airbnb practice of doing that. I agree that we should separate those out. This proposal suggests we split our recommended configurations into:
You can see the equivalent code changes in#5251. Description of Breaking ChangesIn other words, there arethree changes being proposed here:
Thanks@shawnmcknight for a greatTwitter discussion on phrasing the breaking changes! |
BetaWas this translation helpful?Give feedback.
All reactions
👍 4
Replies: 2 comments 6 replies
-
Could I suggest a change? Is it possible we could get a I'd love to extend the I know it's a separate request, but I wanted to mention it here first since it's in direct opposition to half of this change. |
BetaWas this translation helpful?Give feedback.
All reactions
-
I wish we could thread existing discussion comments, since migrating from issues puts them all root-level 🙃 but responding in#6019 (reply in thread): yes! |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
@aaronadamsCA I merged this into the OP |
BetaWas this translation helpful?Give feedback.
All reactions
🎉 1
-
I definitely agree that splitting out So i think it might make sense to continue this theme for |
BetaWas this translation helpful?Give feedback.
All reactions
👍 2
-
Agreed, I really like this. I've also been noodling on getting a less verbose name. The closest I've come up with has been
I'll update the PR. |
BetaWas this translation helpful?Give feedback.
All reactions
-
do we want to rename the configs? that seems like a pretty major breaking change that would impact most of our users. |
BetaWas this translation helpful?Give feedback.
All reactions
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
I like renaming them to draw attention to big shifts, like going from three configs to six. It forces users to take stock of their configs. Especially if To mitigate pain, I'd propose we:
|
BetaWas this translation helpful?Give feedback.
All reactions
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
Chatted privately - we're 👍 to go for now! I merged this into the OP |
BetaWas this translation helpful?Give feedback.
All reactions
This discussion was converted from issue #5204 on November 17, 2022 15:54.