- Notifications
You must be signed in to change notification settings - Fork3
feat: examples for flat configs and type information#4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| npm run lint | ||
| ``` | ||
| ```plaintext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should this be a snapshot or tested or something to validate it does what we expect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
#6 👍 agreed
| ## Setup | ||
| ```shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should probably usenpm2yarn here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
#7 👍 agreed
| import eslint from "@eslint/js"; | ||
| import tseslint from "typescript-eslint"; | ||
| export async function unecessarilyAsync() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we be mixing config and test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Heh, it was the shortest path to getting a.js file linted.
| @@ -3,7 +3,7 @@ | |||
| "version": "0.0.0", | |||
| "description": "Various examples of working with typescript-eslint. 📝", | |||
| "main": "index.js", | |||
| "repository": "https://github.com/typescript-eslint/typescript-eslint-examples", | |||
| "repository": "typescript-eslint/typescript-eslint-examples", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why remove the URL base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Heh I only recently learned this was a thing.JoshuaKGoldberg/eslint-plugin-package-json#71
Uh oh!
There was an error while loading.Please reload this page.
Fixes#3.
Also cleans up the
repositoryfield inpackage.jsonfiles.Note that until v7 is released in two days, the
typescript-eslintpackage needs to be symlinked locally.